https://pantsbuild.org/ logo
Powered by
#general
  • a

    ancient-stone-50795

    02/23/2016, 8:39 PM
    (At one point I had a patch for it but it was shouted down)
  • w

    witty-crayon-22786

    02/23/2016, 8:39 PM
    so you guys only consume the build cache in CI then?
  • a

    ancient-stone-50795

    02/23/2016, 8:39 PM
    Yes, but we have the local build cache turned on.
  • w

    witty-crayon-22786

    02/23/2016, 8:40 PM
    that doesn't help IJ
  • w

    witty-crayon-22786

    02/23/2016, 8:40 PM
    ...without the plugin
  • a

    ancient-stone-50795

    02/23/2016, 8:40 PM
    We are all Java and IJ does lots of good caching too.
  • c

    curved-manchester-66006

    02/23/2016, 9:18 PM
    I've been looking for ways to run checkstyle on individual files (like find -iname *.java | xargs | checkstyle) and not have it be terribly slow. I had not realized there was checkstyle integration in contrib. Could that give me something close to a 'checkstyle-daemon' without needing to write a bespoke checkstyle/nailgun daemon?
  • w

    witty-crayon-22786

    02/23/2016, 9:18 PM
    @curved-manchester-66006: hm, it's not in contrib... it's in core
  • a

    ancient-stone-50795

    02/23/2016, 9:18 PM
    But its not on by default. You do need to turn in on in pants.ini
  • w

    witty-crayon-22786

    02/23/2016, 9:19 PM
    ./pants help-advanced compile.checkstyle
    (edit: advanced)
  • a

    ancient-stone-50795

    02/23/2016, 9:22 PM
    We have it registered in a plugin:
    Copy code
    from pants.backend.jvm.tasks.checkstyle import Checkstyle
from pants.goal.task_registrar import TaskRegistrar as task


def register_goals():
  task(name='checkstyle', action=Checkstyle).install('compile')
  • w

    witty-crayon-22786

    02/23/2016, 9:23 PM
    @ancient-stone-50795: hm... is that necessary? afaik, it's installed by default
  • w

    witty-crayon-22786

    02/23/2016, 9:23 PM
    ...oh. you're right. it's not.
  • w

    witty-crayon-22786

    02/23/2016, 9:24 PM
    wow, that's annoying.
  • a

    ancient-stone-50795

    02/23/2016, 9:24 PM
    We have it turned on in a similar plugin in the pants repo via 
    pants-plugins/src/python/internal_backend/optional/register.py
  • w

    witty-crayon-22786

    02/23/2016, 9:24 PM
    ... i'm super confused now though. how is it enabled in the pantsbuild/pants repo at all?
  • w

    witty-crayon-22786

    02/23/2016, 9:24 PM
    ah
  • a

    ancient-stone-50795

    02/23/2016, 9:25 PM
    Copy code
    [DEFAULT]
backend_packages: [
    "internal_backend.optional",
    ...
    in pants.ini
  • w

    witty-crayon-22786

    02/23/2016, 9:30 PM
    @curved-manchester-66006: so... yea. need to enable it via a pants plugin it looks like... awkward. i've opened https://github.com/pantsbuild/pants/issues/2954 about that
  • c

    curved-manchester-66006

    02/23/2016, 9:32 PM
    Thanks. But to the original question , it piggy backs on the pants nailgun integration and doesn't need to invoke a new jvm each time?
  • w

    witty-crayon-22786

    02/23/2016, 9:33 PM
    that's correct.
  • w

    witty-crayon-22786

    02/23/2016, 9:33 PM
    ...er.
  • w

    witty-crayon-22786

    02/23/2016, 9:33 PM
    @curved-manchester-66006: actually, after the change @ancient-stone-50795 linked to above to disable the user classpath, it won't need a new jvm each time.
  • w

    witty-crayon-22786

    02/23/2016, 9:34 PM
    currently it does. but it only invokes once for all of the targets in the context, which helps with the overhead a bit.
  • c

    curved-manchester-66006

    02/23/2016, 9:35 PM
    Got it. I'll try to take a look and see if it makes sense in the context of my per-file use case.
  • w

    witty-crayon-22786

    02/23/2016, 9:36 PM
    @curved-manchester-66006: but yea, it's all integrated with nailgun.
  • w

    witty-crayon-22786

    02/23/2016, 9:37 PM
    the reason it currently doesn't gain any advantage from nailgun is that the classpath changes each time it runs
  • w

    witty-crayon-22786

    02/23/2016, 9:37 PM
    @curved-manchester-66006: why do you need it to run per-file?
  • c

    curved-manchester-66006

    02/23/2016, 9:38 PM
    I'm exploring integration with an existing tool that currenlty expects it to be per file (
    arc
    from Phabricator). It feels sort of wonky if some linting happens when you run 
    arc lint
    and others happened when you ran some pants goal
  • w

    witty-crayon-22786

    02/23/2016, 9:58 PM
    @ancient-stone-50795: for posterity, doing https://help.github.com/articles/creating-an-access-token-for-command-line-use/ and putting the token and username in netrc for github.com worked for site publishing
1...9989991000...2420Latest