pantsbuild #general

Channels

welcome

github-notifications

announce

rough-minister-58256

02/16/2016, 10:24 PM

so we still excise all of the underlying deprecated code paths, but leave just the options registration purely as no-ops that facilitate hinting.

mammoth-pharmacist-54215

02/16/2016, 10:25 PM

yeah, that make sense

happy-kitchen-89482

02/16/2016, 11:10 PM

Confirming that locally_changed_targets was for faster iteration in the global strategy

happy-kitchen-89482

02/16/2016, 11:11 PM

I don’t think anything needs it, or the coloring stuff, any more

bored-art-40741

02/17/2016, 12:16 AM

Release is finished

bored-art-40741

02/17/2016, 12:16 AM

Sorry for the delay on that

witty-crayon-22786

02/17/2016, 12:24 AM

thanks a bunch patrick

curved-manchester-66006

02/17/2016, 6:26 PM

jenkins bot might have gone kind of crazy again? https://github.com/pantsbuild/pants/pull/2932 Or it really really likes CI?

jolly-chef-92794

02/17/2016, 6:30 PM

Hey, I was reading through

jar_publish.py

, and noticed this issue mentioned in comments: https://github.com/pantsbuild/pants/issues/65

jolly-chef-92794

02/17/2016, 6:30 PM

Has there been any further work/thoughts on this?

jolly-chef-92794

02/17/2016, 6:31 PM

It would help with a couple problems we’re having at Square.

jolly-chef-92794

02/17/2016, 6:31 PM

1: Publishing java_protobuf_libraries with both the compiled java classes and the .proto files — a

source_library

could easily combine these together

jolly-chef-92794

02/17/2016, 6:33 PM

2: Building a binary of a project needs to use sources files from other projects separately from the rest of the source files in those projects, when the source files don’t compile by themselves

jolly-chef-92794

02/17/2016, 6:42 PM

I see this comment in the issue:

Copy code

How to make sure, there is 1:1 correspondence between source_libraries and libraries?
This only affects publishing.
Is it pants which should not allow same sources to be part of different libs or the consumers to write good/clean  build files?

I think we (a) don’t want a 1:1 correspondence, eg for things like protobuf libraries it’s valid to use the same .proto sources for both Wire and Protobuf libraries, and potentially for different kinds of proto libraries (java vs python vs ruby etc). (b) This may not affect publishing exclusively, as use-case 2. mentions above

witty-crayon-22786

02/17/2016, 6:46 PM

i've argued in the past for using the facility that already exists to publish the source of a library

witty-crayon-22786

02/17/2016, 6:46 PM

ie, the

-sources

classifier

witty-crayon-22786

02/17/2016, 6:47 PM

...in this case i guess that would mean mixing the idl and the source into one jar?

witty-crayon-22786

02/17/2016, 6:53 PM

but alternatively, an

-idl

classifier

jolly-chef-92794

02/17/2016, 7:08 PM

@witty-crayon-22786: This particular case is tricky because we don’t want the java sources - we want the classes from the synthetic java_library, and the sources from the java_protobuf_library

jolly-chef-92794

02/17/2016, 7:08 PM

And in another project (due to terrible external dependencies) it would be extremely helpful to be able to depend on individual source files from other projects

witty-crayon-22786

02/17/2016, 7:09 PM

seems like an easy fix would be to include the sources for all derived targets in the sources jar

jolly-chef-92794

02/17/2016, 7:09 PM

Well, but that would include the

.java

files too, wouldn’t it?

jolly-chef-92794

02/17/2016, 7:09 PM

We just want the

.proto

and

.class

files

witty-crayon-22786

02/17/2016, 7:10 PM

not much of a hardship to include the java as well

witty-crayon-22786

02/17/2016, 7:10 PM

but that would be a good argument for the

-idl

classifier

witty-crayon-22786

02/17/2016, 7:11 PM

if you really needed them separate from the sources.

limited-terabyte-34878

02/17/2016, 7:11 PM

thanks @happy-kitchen-89482 and @witty-crayon-22786 for shipping those two TestFailedTaskError issues. I was away on vaca the past 2 weeks.

jolly-chef-92794

02/17/2016, 7:17 PM

What determines whether

jar_publish.py

publishes sources/javadocs/etc? I don’t see an option for it. I see that it pulls something out of the context products, but I don’t know where that is set by the user

witty-crayon-22786

02/17/2016, 7:18 PM

@jolly-chef-92794: if they exist they are published

witty-crayon-22786

02/17/2016, 7:18 PM

so if you

--skip

the tasks that create those products, they're not published