https://pantsbuild.org/ logo
Powered by
#general
  • m

    mammoth-pharmacist-54215

    02/10/2016, 11:36 PM
    that is probably what happened.
  • w

    witty-crayon-22786

    02/10/2016, 11:37 PM
    just pushed a fix
  • m

    mammoth-pharmacist-54215

    02/10/2016, 11:37 PM
    yeah, but if I push a fix it will build in the PR but that doesn’t update the RB automatically
  • w

    witty-crayon-22786

    02/10/2016, 11:37 PM
    in d99dbc51481b466026a565fd2dec98872efbd88f
  • r

    rough-minister-58256

    02/10/2016, 11:37 PM
    ah
  • a

    adorable-glass-89507

    02/11/2016, 9:57 AM
    is anyone using jenkins and aggregating test results from pants from junit tests?
  • a

    adorable-glass-89507

    02/11/2016, 9:58 AM
    I don't quite understand which files I should use for the report
  • f

    fast-megabyte-33579

    02/11/2016, 10:46 AM
    we do
  • f

    fast-megabyte-33579

    02/11/2016, 10:46 AM
    we use everything under 
    .pants.d/test/junit/*.xml
  • f

    flat-kitchen-27511

    02/11/2016, 12:14 PM
    is there a way for me to add arbitrary files to python binaries? Like if I wanted to add a JS file from somewhere else?
  • c

    curved-manchester-66006

    02/11/2016, 1:38 PM
    koddsson: check out resource_targets and pkgutil.get_data. I think that's along the lines of what you want
  • f

    flat-kitchen-27511

    02/11/2016, 1:40 PM
    Allright, I'll check that out. Thanks @curved-manchester-66006
  • c

    curved-manchester-66006

    02/11/2016, 1:42 PM
    Re style errors getting through CI(s). With Phabricator linters are usually run locally as part of the patch submission process, does review board have a similar feature?
  • a

    adorable-glass-89507

    02/11/2016, 2:06 PM
    @fast-megabyte-33579: cool, I'll try that out
  • j

    jolly-chef-92794

    02/11/2016, 5:33 PM
    Bug fix for a silly mistake: https://rbcommons.com/s/twitter/r/3452/
  • w

    witty-crayon-22786

    02/11/2016, 6:24 PM
    @curved-manchester-66006: pants supports lots of python linters. but you have to turn them on explicitly
  • w

    witty-crayon-22786

    02/11/2016, 7:11 PM
    @wide-energy-11069: i believe the arguments to 
    register
    are all available in a 
    kwargs
    field
  • w

    witty-crayon-22786

    02/11/2016, 7:11 PM
    but haven't worked with that code
  • w

    wide-energy-11069

    02/11/2016, 7:11 PM
    k
  • w

    witty-crayon-22786

    02/11/2016, 7:26 PM
    self.context
    has gotten positively svelt... thank you to everyone who has been pruning in there.
  • w

    witty-crayon-22786

    02/11/2016, 7:30 PM
    also, til: 
    ./pants check_published_deps ::
    ... but only because it's using 
    self.context.scan
  • b

    bored-art-40741

    02/11/2016, 8:20 PM
    Does this not work, or am I being dumb?
    Copy code
    resources(
  name = 'foo',
  sources = globs('*', 'some_subdir/*'),
)
  • b

    bored-art-40741

    02/11/2016, 8:20 PM
    I'm getting
  • b

    bored-art-40741

    02/11/2016, 8:20 PM
    Copy code
    Exception message: Problem validating target src.webapp.static.foo.foo in src/webapp/static/foo: [Errno 21] Is a directory: u'/Users/pl/code/foursquare.web/src/webapp/static/foo/some_subdir'
  • b

    bored-art-40741

    02/11/2016, 8:21 PM
    It seems like the first glob is picking up the existence of a subdir and choking on it
  • b

    bored-art-40741

    02/11/2016, 8:21 PM
    Can double check that
  • b

    bored-art-40741

    02/11/2016, 8:21 PM
    Yeah, it's not the second piece of the glob, it's the first
  • b

    bored-art-40741

    02/11/2016, 8:21 PM
    ugh
  • b

    bored-art-40741

    02/11/2016, 8:22 PM
    How long has this been broken?
  • w

    witty-crayon-22786

    02/11/2016, 8:23 PM
    seems like it might be a pretty specific case
1...978979980...2420Latest