#general
- j
jolly-chef-92794
02/03/2016, 3:45 PMNo, it has to have been released more recently than that, because the java8 fixes I did were in September. I guess maven central is not up to date - j
jolly-chef-92794
02/03/2016, 3:46 PMOh, I was looking at the wrong group name (org.pantsbuild.jarjar), it was released on the 1st. ok - w
witty-crayon-22786
02/03/2016, 6:13 PMyea, dturner did a release just recently. - r
red-cpu-25099
02/03/2016, 6:49 PMI'm currently working on
option which seems likepants_build_ignore
for pants.gitignore
files. Currently it's implemented as pants list option with default to '.*' (which stands for all directories and files with dot at the beginning). @happy-kitchen-89482 comes with suggestion to introduceBUILD
file which will be the same as.pantsignore
for pants + option to specify path to this file. What do you prefer?.gitignore - b
bored-art-40741
02/03/2016, 6:50 PM+1 for.pantsignore - b
bored-art-40741
02/03/2016, 6:50 PMThis is fundamentally global, it uses
syntax anyway, and people will be familiar with that.gitignore - w
witty-crayon-22786
02/03/2016, 6:51 PMimo, additional config files are something we should be fighting - b
bored-art-40741
02/03/2016, 6:51 PMThough maybe it should be
or something to emphasize that it only ignores BUILD files, not other things.pants_build_ignore - w
witty-crayon-22786
02/03/2016, 6:51 PMpeople already think
is "special"BUILD.tools - w
witty-crayon-22786
02/03/2016, 6:51 PM@bored-art-40741: i think that there would be nearly zero overlap between the two files though - b
bored-art-40741
02/03/2016, 6:51 PMNot saying there should be - w
witty-crayon-22786
02/03/2016, 6:51 PM(except the syntax) - r
red-cpu-25099
02/03/2016, 6:53 PM
is not global to repository, you can paste a lot of them in different folders, from this point of view I prefer one option.gitignore - b
bored-art-40741
02/03/2016, 6:54 PMThe root
is, though yes we shouldn't support or give the expectation of supporting nested.gitignore
files if we go that route.pantsignore - b
bored-art-40741
02/03/2016, 6:55 PMI don't feel too strongly about this. I agree with Benjy that it's much nicer in practice to write a single
-style file, and I think users will find it comfortable. But I also don't mind just sticking this in pants.ini.ignore - r
red-cpu-25099
02/03/2016, 6:59 PMMy vote goes to list option and let's see how people will use it. Currently it's
but I'm looking to change it to just--pants-build-ignore
, what do you think?--build-ignore - r
rough-minister-58256
02/03/2016, 7:00 PMimo, seems better to consolidate configuration like this in pants.ini vs sprawling to one-off config files - b
bored-art-40741
02/03/2016, 7:00 PMMaybe--build-file-ignore - b
bored-art-40741
02/03/2016, 7:01 PM
is a super overloaded term, and this is specific to BUILD filesbuild - w
witty-crayon-22786
02/03/2016, 7:02 PM@jolly-chef-92794: seen https://rbcommons.com/s/twitter/r/3405/ ? - j
jolly-chef-92794
02/03/2016, 7:03 PM@witty-crayon-22786: I hadn’t. Does that include the bugfix I landed yesterday? - w
witty-crayon-22786
02/03/2016, 7:03 PMno, from 2 days ago - w
witty-crayon-22786
02/03/2016, 7:03 PMbut you might ping him to rerun it, or do your own i suppose - w
witty-crayon-22786
02/03/2016, 7:04 PMor i could re-release if you need it - j
jolly-chef-92794
02/03/2016, 7:05 PMrerun = re-release it? That would be helpful for us, we have an existing broken project that developers are working around with
shenanigans to patch in a locally built jarjarurl=file://... - j
jolly-chef-92794
02/03/2016, 7:05 PMI’m also okay landing that RB now and circling back to do it again shortly after though, whatever works - w
witty-crayon-22786
02/03/2016, 7:06 PM@kind-holiday-68516: since you're warmed up, mind re-running the jarjar release? - w
witty-crayon-22786
02/03/2016, 7:06 PMif so i can - k
kind-holiday-68516
02/03/2016, 7:06 PMno problem - w
witty-crayon-22786
02/03/2016, 7:07 PMthanks much. in return maybe @jolly-chef-92794 can shipit the version bump