#general
- b
bored-art-40741
02/02/2016, 9:11 PMI really wish we could just get rid of java_sources - w
witty-crayon-22786
02/02/2016, 9:12 PMwe can probably. - w
witty-crayon-22786
02/02/2016, 9:12 PMand should, most likely. - b
bored-art-40741
02/02/2016, 9:12 PMIs Twitter done with it? - b
bored-art-40741
02/02/2016, 9:12 PMWe never had to worry about it, because of
as opposed tosrc/jvmsrc/{java,scala} - m
many-engine-77019
02/02/2016, 9:13 PM - w
witty-crayon-22786
02/02/2016, 9:13 PMthe thing is, even with multiple directories, you can still just concoct a globs to make it work - b
bored-art-40741
02/02/2016, 9:13 PMReally? But then doesn't the target have to live way up at the root of your repo? - w
witty-crayon-22786
02/02/2016, 9:14 PM...mm. for science layout, yes. - j
jolly-chef-92794
02/02/2016, 9:50 PMOne of our devs found a sneaky jarjar bug. Fix here: https://github.com/pantsbuild/jarjar/pull/17 - m
mammoth-pharmacist-54215
02/02/2016, 10:24 PMFrom what I understand we previously used sphinx for docgen in pants but now we use a custom set of scripts. Was the motivation for that just to be able to use markdown or was there more to it? - w
witty-crayon-22786
02/02/2016, 10:27 PM@mammoth-pharmacist-54215: the BUILD dictionary is one of the reasons - m
mammoth-pharmacist-54215
02/02/2016, 10:27 PMnot sure that excludes using sphinx - m
mammoth-pharmacist-54215
02/02/2016, 10:28 PMany custom docs we generate could be done as a first pass and then sphinx could include those docs. - w
witty-crayon-22786
02/02/2016, 10:31 PMlarry would know the most about the history. - w
witty-crayon-22786
02/02/2016, 10:31 PM...but it should all be in the git log too. - m
mammoth-pharmacist-54215
02/02/2016, 10:32 PMthe reason I ask is looking at how to expose the api docs. The way the build dictionary works relies on having all the objects registered in some way. This way our code can get access to the docstrings. - w
witty-crayon-22786
02/02/2016, 10:33 PMwouldn't a recursive loop through modules work? - m
mammoth-pharmacist-54215
02/02/2016, 10:33 PMish - m
mammoth-pharmacist-54215
02/02/2016, 10:34 PMyou could probably write something that looks at the ast for the files. - m
mammoth-pharmacist-54215
02/02/2016, 10:34 PMbut a lot of that is stuff thats already built into sphinx - m
mammoth-pharmacist-54215
02/02/2016, 10:37 PMObviously its a solvable problem to do in house. It’s probably a lot easier to write as a sphinx extension though. Adding markdown support to sphinx doesn’t seem insurmountable either. - a
adorable-glass-89507
02/02/2016, 10:41 PM@red-cpu-25099, @bored-art-40741: ah I'll ask them to use this link, thanks - w
witty-crayon-22786
02/02/2016, 11:07 PM@jolly-chef-92794: #shipit for https://github.com/pantsbuild/jarjar/pull/17 .. sorry for the delay👍 1 - m
mammoth-pharmacist-54215
02/03/2016, 12:25 AMregarding public/private, would people still prefer that public methods be moved out of tests? - m
mammoth-pharmacist-54215
02/03/2016, 12:27 AMthere was some discussion about moving some things from tests to src I was going to start this effort but I wanted to make sure people’s opinions haven’t changed. - w
witty-crayon-22786
02/03/2016, 12:28 AM@mammoth-pharmacist-54215: might be a good thing to do post-marking - m
mammoth-pharmacist-54215
02/03/2016, 12:29 AMyeah, I would see it as a 2 step process… otherwise you may do a lot of refactor work only to find out people disagree what is public. - b
better-park-26723
02/03/2016, 12:36 AMDoes Pants build targets in parallel? If I want to build X which depends on two independent projects A and B, can Pants build A and B in parallel? - w
witty-crayon-22786
02/03/2016, 12:37 AMfor the jvm, yes.