https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    02/01/2016, 11:01 PM
    and it would be nice to be able to at the file level
  • b

    bored-art-40741

    02/01/2016, 11:02 PM
    We can also enforce those kinds of privacy issues with graph rules, which we shouldn't expect users to be doing for their loose source plugins
  • w

    witty-crayon-22786

    02/01/2016, 11:02 PM
    true.
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:03 PM
    So if we did a proxy like Kris had suggested wouldn’t we be able to leave most of the code as is and just change what is exposed in the proxy?
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:03 PM
    it sounds like it would be a one time hit for updating plugins for users.
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:04 PM
    and we can hide whatever conventions we use internally from our users
  • b

    bored-art-40741

    02/01/2016, 11:04 PM
    I'm also not a fan of a proxy
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:04 PM
    curious why
  • b

    bored-art-40741

    02/01/2016, 11:04 PM
    It's not as crazy as an importer, but it makes discoverability more difficult for people reading the code
  • b

    bored-art-40741

    02/01/2016, 11:04 PM
    And let's be honest: you have to read the code to develop a pants plugin
  • w

    witty-crayon-22786

    02/01/2016, 11:04 PM
    yes.
  • b

    bored-art-40741

    02/01/2016, 11:06 PM
    In all of these decisions, we have to imagine someone fresh and green coming in and trying to figure out pants, e.g. what d.fabulich has been doing
  • b

    bored-art-40741

    02/01/2016, 11:06 PM
    And as soon as we do anything more complicated than naming conventions, we've added an extra layer of complexity to an already tenuously complex pile of information that newcomers need to grok
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:07 PM
    fair point.
  • w

    witty-crayon-22786

    02/01/2016, 11:07 PM
    i don't see how 
    _
    is particularly self documenting
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:07 PM
    \_(ツ)_/¯ for python users its pretty common
  • b

    bored-art-40741

    02/01/2016, 11:07 PM
    Yeah it's python convention, and it's also a rule you can document with a single sentence
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:07 PM
    _ means don’t touch.
  • w

    witty-crayon-22786

    02/01/2016, 11:07 PM
    @mammoth-pharmacist-54215: and yet, that's not what it will be being used for here
  • r

    rough-minister-58256

    02/01/2016, 11:08 PM
    _ on me
  • b

    bored-art-40741

    02/01/2016, 11:08 PM
    That users can then see with a glance
  • w

    witty-crayon-22786

    02/01/2016, 11:08 PM
    it will mean something else
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:08 PM
    @witty-crayon-22786: what do you mean it will be used for something else?
  • w

    witty-crayon-22786

    02/01/2016, 11:08 PM
    we'll be using it not to mean "private to this module", but instead "not for end users"
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:08 PM
    I see what you mean.
  • b

    bored-art-40741

    02/01/2016, 11:09 PM
    I'm a fan of 
    pantsbuild.pants.backend.jvm._private.stuff
  • m

    mammoth-pharmacist-54215

    02/01/2016, 11:09 PM
    thats mostly confusing for people in pants though… for pants users it means don’t touch it either way.
  • b

    bored-art-40741

    02/01/2016, 11:09 PM
    Yes it mildly conflates 
    _...
    meaning package private
  • w

    witty-crayon-22786

    02/01/2016, 11:09 PM
    as patrick said, they will need to read the code
  • b

    bored-art-40741

    02/01/2016, 11:09 PM
    But it does differentiate, and if we're consistent I think it does so well
1...943944945...2420Latest