#general
- w
witty-crayon-22786
02/01/2016, 10:47 PMmm - b
bored-art-40741
02/01/2016, 10:47 PMYou can annotate the object being returned by the decorator without wrapping it - r
rough-minister-58256
02/01/2016, 10:47 PMah hm - b
bored-art-40741
02/01/2016, 10:48 PMI'm not sold on the decorator scheme, but I do not think perf is an issue - w
witty-crayon-22786
02/01/2016, 10:48 PMand i can't see a good reason to do any wrapping here.... except perhaps in master to make things noisy in some cases - w
witty-crayon-22786
02/01/2016, 10:48 PM(can't think of which cases) - b
bored-art-40741
02/01/2016, 10:48 PMI think wrapping would be strictly bad, mostly because how do you know where you're being called from? - r
rough-minister-58256
02/01/2016, 10:48 PMyeah, thought the point would be to throw warnings/blow up - b
bored-art-40741
02/01/2016, 10:48 PMThat's the only time you should make noise - w
witty-crayon-22786
02/01/2016, 10:48 PMyea. - w
witty-crayon-22786
02/01/2016, 10:48 PMoh... check ENV var - w
witty-crayon-22786
02/01/2016, 10:48 PM..ah, crap. i had this exact train of thought last time, heh - w
witty-crayon-22786
02/01/2016, 10:49 PMnevermind. - b
bored-art-40741
02/01/2016, 10:49 PMYou just can't know without inspecting the stack - b
bored-art-40741
02/01/2016, 10:49 PMwhich is out of the question - w
witty-crayon-22786
02/01/2016, 10:49 PManyway: i think even as strictly a marker with no wrapping it would be better to use decorators than rename a bunch of stuff - b
bored-art-40741
02/01/2016, 10:49 PMThe reasoning for renaming stuff was that it was obvious in your imports if you were relying on a private API - m
mammoth-pharmacist-54215
02/01/2016, 10:50 PMfor modules we could use docstrings something like API:public - b
bored-art-40741
02/01/2016, 10:50 PMI think being explicit here is better than waiting for runtime - m
mammoth-pharmacist-54215
02/01/2016, 10:50 PM@bored-art-40741: what do you mean by being explicit? - b
bored-art-40741
02/01/2016, 10:50 PMThe best way for a user to know if they're violating public/private boundaries is for them to see it in their imports. If they imports have modules with leading underscores, that's a universally understood notation for "private" - b
bored-art-40741
02/01/2016, 10:51 PMIf the methods/attributes they're accessing have leading underscores or "private" prefixes, that's also universally understood - b
bored-art-40741
02/01/2016, 10:51 PMIt's the least surprising way to annotate this information - b
bored-art-40741
02/01/2016, 10:51 PMFurthermore, I don't think we should blow up at runtime even if we could - b
bored-art-40741
02/01/2016, 10:51 PMWe want to make it obvious that an API is private and subject to change - r
rough-minister-58256
02/01/2016, 10:51 PMhow do we distinguish between internally-private and externally-private in that scheme tho - b
bored-art-40741
02/01/2016, 10:51 PMBut users are adults and they can choose to use those private APIs if they want - b
bored-art-40741
02/01/2016, 10:52 PMexternally private is modules with underscores - b
bored-art-40741
02/01/2016, 10:52 PMInternally private is normal conventions for privacy, namely _ prefixes - m
mammoth-pharmacist-54215
02/01/2016, 10:52 PMthe doc Eric wrote had private_ be used by other modules and _ only used in the current module.