https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    01/26/2016, 5:50 AM
    for example
  • b

    bored-art-40741

    01/26/2016, 5:51 AM
    Maybe we just need to establish an integration "I'm shelling out" base config that sets the standard ivy/pex cache dirs to something repo local
  • b

    better-park-26723

    01/26/2016, 5:55 AM
    How would I build a war file with Pants?
  • b

    bored-art-40741

    01/26/2016, 5:01 PM
    @better-park-26723: You can either build a regular (loose) bundle and then put it together yourself after with a script, or you can write a subclass of 
    BundleCreate
    that puts it together for you
  • b

    bored-art-40741

    01/26/2016, 5:03 PM
  • b

    bored-art-40741

    01/26/2016, 5:03 PM
    Almost entirely just to inject that version file, but you can imagine using that same interface to rearrange the jar produced
  • b

    better-park-26723

    01/26/2016, 5:09 PM
    @bored-art-40741: Seems like war functionality should be a proper feature. Is the best way to make that a PR for Pants itself? Or would I make a plugin of some kind?
  • b

    bored-art-40741

    01/26/2016, 5:10 PM
    Generally we try to move things through contrib before they land in core. Which is to say it's a plugin maintained by core pants
  • b

    bored-art-40741

    01/26/2016, 5:10 PM
    But we also have an explicit JVM backend and it seems reasonable to me to land it straight into there
  • b

    bored-art-40741

    01/26/2016, 5:10 PM
    As far as how to contribute upstream, it's slightly more complicated than just a PR, though yes I'd encourage you to do so
  • b

    better-park-26723

    01/26/2016, 5:11 PM
    Where would I get started?
  • b

    bored-art-40741

    01/26/2016, 5:11 PM
  • b

    better-park-26723

    01/26/2016, 5:11 PM
    well, I mean, that's how to submit a PR, right? but you said it'd be more complicated?
  • b

    better-park-26723

    01/26/2016, 5:11 PM
    or are you just saying that it's more complicated because of rbcommons?
  • b

    bored-art-40741

    01/26/2016, 5:11 PM
    The latter
  • m

    many-engine-77019

    01/26/2016, 5:12 PM
    more complicated than a github PR
  • b

    better-park-26723

    01/26/2016, 5:12 PM
    gotcha
  • b

    bored-art-40741

    01/26/2016, 5:12 PM
    This is the general neighborhood of the code related to what you're suggesting: https://github.com/pantsbuild/pants/tree/master/src/python/pants/backend/jvm
  • b

    better-park-26723

    01/26/2016, 5:12 PM
    cool
  • b

    bored-art-40741

    01/26/2016, 5:12 PM
    You'd likely want to make a task called 
    WarBinary
    that subclasses 
    BundleCreate
  • b

    bored-art-40741

    01/26/2016, 5:12 PM
  • r

    rough-minister-58256

    01/26/2016, 6:04 PM
    wonder if we should consider rolling this out for pants src: https://github.com/google/yapf
  • r

    rough-minister-58256

    01/26/2016, 6:04 PM
    basically gofmt for python
  • w

    witty-crayon-22786

    01/26/2016, 6:06 PM
    will need to start by adding a task for it
  • w

    witty-crayon-22786

    01/26/2016, 6:07 PM
    but would certainly be better than having an external script to run 
    isort
  • r

    rough-minister-58256

    01/26/2016, 6:10 PM
    more curious if folks are into the idea of it
  • r

    rough-minister-58256

    01/26/2016, 6:11 PM
    autoformatting can be a mixed bag fwict
  • w

    witty-crayon-22786

    01/26/2016, 6:12 PM
    i'm definitely into having it implemented in pants, as long as it is a manual step
  • r

    rough-minister-58256

    01/26/2016, 6:13 PM
    word. was thinking about adding a mypy task too
  • b

    bored-art-40741

    01/26/2016, 6:17 PM
    Does anyone know where ivy gets its non-environment parameters from in an ivysettings.xml?
1...911912913...2420Latest