pantsbuild #general

but if you wanted a task that invokved webpack directly without npm*, you'd want to take a look at the existing node tasks, and then add one to skip the npm portion

witty-crayon-22786

01/25/2016, 9:08 PM

https://github.com/pantsbuild/pants/blob/master/contrib/node/README.md

better-park-26723

01/25/2016, 9:10 PM

thanks

better-park-26723

01/25/2016, 9:10 PM

I've got a lot of reading to do! simple smile

adorable-glass-89507

01/25/2016, 10:00 PM

I've been meaning to do a spike on custom node/npm plugin where we cache the npm install's (package.json & shrinkwraps) but link the source tree somehow (npm link maybe?). I feel like I could make webpack, react and hot-reloading work with that somehow... Not sure though. I'd love to discuss this with someone who's working on solving browser apps development with pants.

rough-minister-58256

01/25/2016, 10:00 PM

@adorable-glass-89507: would definitely chat with @bright-dinner-81701 re: this.

adorable-glass-89507

01/25/2016, 10:02 PM

yeah I had a quick chat with him about this in nov/dec, I've been meaning to do more work on it but been blocked by other things

rough-minister-58256

01/25/2016, 10:03 PM

a good way to collabo more asynchronously/get broader feedback is to throw your design ideas in a google doc and open that up to the pants-devel@ google group for comments

rough-minister-58256

01/25/2016, 10:03 PM

then folks can do drive-bys etc on approach even if they’re less familiar with the node ecosystem

bored-art-40741

01/25/2016, 10:04 PM

I've thought about this problem a bit since we have a related issue internally

bored-art-40741

01/25/2016, 10:04 PM

I also think that with some clever symlink farming we can get hot reloading to work without violating any major pants assumptions

adorable-glass-89507

01/25/2016, 10:04 PM

@rough-minister-58256: thanks, I'll do that

rough-minister-58256

01/25/2016, 10:04 PM

👍

bored-art-40741

01/25/2016, 10:05 PM

The catch would be that if you actually changed dependencies or added/removed files, it would probably require a rebuild

adorable-glass-89507

01/25/2016, 10:05 PM

@bored-art-40741: I've thought about that as well

adorable-glass-89507

01/25/2016, 10:05 PM

webpack handles add/remove files

adorable-glass-89507

01/25/2016, 10:05 PM

in general, iirc

adorable-glass-89507

01/25/2016, 10:06 PM

it's fine by me if I have to stop webpack when changing package.json/shrinkwrap

adorable-glass-89507

01/25/2016, 10:06 PM

anyway, I'll write up a google doc and post

ancient-stone-50795

01/25/2016, 10:07 PM

@better-park-26723: there are 2 targets in pants that can help you inject scripts and java code prep_command() and jvm_prep_command(). They won't help you with codegen, however.

bright-dinner-81701

01/25/2016, 10:33 PM

@adorable-glass-89507 @rough-minister-58256 yeah write up how it would work

bright-dinner-81701

01/25/2016, 10:33 PM

so a big problem before was that npm 2 is so bad

bright-dinner-81701

01/25/2016, 10:33 PM

but

bright-dinner-81701

01/25/2016, 10:33 PM

i just moved the open source pants to node 5.5, which bundles npm 3, last week

bright-dinner-81701

01/25/2016, 10:34 PM

npm 3 may be able to avoid pointlessly rebuilding and downloading packages arbitrarily eetc

bright-dinner-81701

01/25/2016, 10:34 PM

like, npm 2 link rebuilt native code for example

bright-dinner-81701

01/25/2016, 10:34 PM

it was unusable in every formulation we tried

adorable-glass-89507

01/25/2016, 10:53 PM

thanks @bright-dinner-81701, I'll write up how we'd like it to work and ideas to get there