https://pantsbuild.org/ logo
Powered by
#general
  • w

    wide-energy-11069

    01/22/2016, 9:03 PM
  • a

    ancient-stone-50795

    01/22/2016, 9:04 PM
    release is out
    🎉 2
  • j

    jolly-chef-92794

    01/22/2016, 9:04 PM
    @wide-energy-11069 looking at that review now
  • a

    ancient-stone-50795

    01/22/2016, 9:04 PM
    @wide-energy-11069 I'm interested in the plugin, but we don't have many users using it yet
  • a

    ancient-stone-50795

    01/22/2016, 9:05 PM
    I don't think I'll have time to take a look (I'm oncall)
  • w

    wide-energy-11069

    01/22/2016, 9:07 PM
    Sure no worries
  • j

    jolly-chef-92794

    01/22/2016, 9:09 PM
    @wide-energy-11069 lgtm
  • w

    wide-energy-11069

    01/22/2016, 9:09 PM
    Thanks!
  • f

    fancy-queen-20734

    01/22/2016, 10:03 PM
    @jolly-chef-92794: we’d started on refactoring ivy_task_mixin a little prior to starting to break things up, but haven’t gotten too far with it yet. Are you doing many structural changes?
  • j

    jolly-chef-92794

    01/22/2016, 10:04 PM
    @fancy-queen-20734: Not many, you can take a peek (waiting on ci before putting it up on review board): https://github.com/pantsbuild/pants/pull/2830
  • f

    fancy-queen-20734

    01/22/2016, 10:05 PM
    @jolly-chef-92794: funnily enough, I’d pushed ours up here https://github.com/pantsbuild/pants/pull/2828/files
  • f

    fancy-queen-20734

    01/22/2016, 10:06 PM
    It’s funny how even though we’re working on similar things, I think our changes are mostly non-overlapping
  • j

    jolly-chef-92794

    01/22/2016, 10:08 PM
    Yeah; it looks like there will be a couple merge conflicts just because I touched some of the method signatures near your changes, but it doesn’t look like we’ll have any actual difficulties
  • w

    wide-energy-11069

    01/22/2016, 10:30 PM
  • w

    wide-energy-11069

    01/22/2016, 10:30 PM
    "We've identified that we're seeing some large spikes in network bandwidth which caused the slowdown. We're evaluating what we can do to mitigate this. "
  • a

    ancient-stone-50795

    01/22/2016, 10:31 PM
    Maybe that explains why the release merge failed...
  • a

    ancient-stone-50795

    01/22/2016, 10:31 PM
    They looked like download errors. I re-ran it and it passed
  • j

    jolly-chef-92794

    01/22/2016, 10:44 PM
    @witty-crayon-22786: I’m trying to figure out what you meant regarding macros and 3rdparty dependencies — do you mean generated 
    jar_library
    objects from 
    managed_dependencies
    , kind of how 
    python_requirements
    works?
  • w

    witty-crayon-22786

    01/22/2016, 10:48 PM
    @jolly-chef-92794: 
    PythonRequirementLibrary
    isn't a macro, iirc
  • w

    witty-crayon-22786

    01/22/2016, 10:50 PM
    @jolly-chef-92794: see https://rbcommons.com/s/twitter/r/3301/ where Benjy overhauled on the macros
  • w

    witty-crayon-22786

    01/22/2016, 10:51 PM
    oh, i see what you mean. yes: the other way around. 
    src/python/pants/backend/python/pants_requirement.py
    is a macro which generates the more verbose form
  • j

    jolly-chef-92794

    01/22/2016, 10:52 PM
    Ok
  • j

    jolly-chef-92794

    01/22/2016, 10:53 PM
    So you’d suggest a macro which generated a 
    managed_jar_dependencies()
    target with artifacts populated from a BUILD file?
  • w

    witty-crayon-22786

    01/22/2016, 10:53 PM
    the macro can generate lots of targets
  • w

    witty-crayon-22786

    01/22/2016, 10:54 PM
    so, depending on layout, you might generate all of the jar_library definitions for a particular resolution
  • w

    witty-crayon-22786

    01/22/2016, 10:54 PM
    etc
  • w

    witty-crayon-22786

    01/22/2016, 10:54 PM
    it's definitely a bit limited, but.
  • j

    jolly-chef-92794

    01/22/2016, 10:55 PM
    So that would work like python_requirements then; it’d generate jar_library definitions for every coordinate in the pinned_artifact_set
  • j

    jolly-chef-92794

    01/22/2016, 10:56 PM
    So you could access them like 
    3rdparty/managed:….
    if you had a 
    managed_jar_dependencies
    in 
    3rdparty/managed/BUILD
    (though at that point maybe it’d make sense to put them in 
    3rdparty/BUILD.managed
    or something)
  • j

    jolly-chef-92794

    01/23/2016, 12:09 AM
    Dependency management part 2 up for review here: https://rbcommons.com/s/twitter/r/3367/ Haven’t been able to run it through full CI yet because of Travis issues, but I figure that doesn’t stop people from discussing the design.
1...904905906...2420Latest