https://pantsbuild.org/ logo
Powered by
#general
  • m

    mammoth-autumn-2551

    07/29/2015, 5:40 PM
    was that binary used for python generation as well?
  • e

    enough-analyst-54434

    07/29/2015, 5:40 PM
    yes
  • m

    mammoth-autumn-2551

    07/29/2015, 5:41 PM
    gotcha
  • m

    mammoth-autumn-2551

    07/29/2015, 5:41 PM
    cool, let me try that
  • m

    mammoth-autumn-2551

    07/29/2015, 5:42 PM
    Is there a pants goal to fetch those binaries, if I want to write some other script but keep the same version of thrift?
  • e

    enough-analyst-54434

    07/29/2015, 5:42 PM
    No - not exposed as a goal
  • e

    enough-analyst-54434

    07/29/2015, 5:42 PM
    You could write one though pretty easily, the fetching is all wrapped up in a Subsystem
  • e

    enough-analyst-54434

    07/29/2015, 5:45 PM
    Roughly:
  • e

    enough-analyst-54434

    07/29/2015, 5:45 PM
    class ThriftBinaryFetcher(Task): @classmethod def task_subsystems(cls): return super(ThriftBinaryFetcher, cls).task_subsystems() + (ThriftBinary.Factory,) def execute(self): thrift_binary = ThriftBinary.Factory.scoped_instance(self).create() version = thrift_binary.version version = thrift_binary.path # This does the fetch and cache if its never been done
  • m

    mammoth-autumn-2551

    07/29/2015, 5:48 PM
    Thanks!
  • m

    mammoth-autumn-2551

    07/29/2015, 5:52 PM
    hmm, 
    [thrift-binary] version: 0.5.0-finagle
    doesn’t seem to do the trick. When I run 
    ./pants -ldebug test tests/python/::
    I still see: ```
  • m

    mammoth-autumn-2551

    07/29/2015, 5:52 PM
    Copy code
    Generating thrift for src/thrift/urbancompass/valuation/valuation.thrift

                   Executing: /Users/paul/.cache/pants/bin/thrift/mac/10.10/0.9.2/thrift --gen py:new_style,utf8strings -recurse -verbose -I src/thrift -I tests/thrift/urbancompass -o /Users/paul/development/urbancompass/.pants.d/gen/thrift/sessions/src.thrift.urbancompass.valuation.valuation.thrift src/thrift/urbancompass/valuation/valuation.thrift
  • m

    mammoth-autumn-2551

    07/29/2015, 5:53 PM
    this is immediately after a 
    git clean -fdx .pants.d
    as well
  • m

    mammoth-autumn-2551

    07/29/2015, 5:53 PM
    (pants 0.0.39)
  • m

    mammoth-autumn-2551

    07/29/2015, 5:55 PM
    rolling back to prior version of pants works:
    Copy code
    Generating thrift for src/thrift/urbancompass/sell_my_home/sell_my_home.thrift

                   Executing: /Users/paul/.cache/pants/bin/thrift/mac/10.10/0.5.0-finagle/thrift --gen py:new_style,utf8strings -recurse -verbose -I src/thrift -I tests/thrift/urbancompass -o /Users/paul/development/urbancompass/.pants.d/gen/thrift/sessions/src.thrift.urbancompass.sell_my_home.sell_my_home.thrift src/thrift/urbancompass/sell_my_home/sell_my_home.thrift
  • e

    enough-analyst-54434

    07/29/2015, 5:58 PM
    OK - just a sec, I may have my features and pants versions crossed on the config
  • m

    mammoth-autumn-2551

    07/29/2015, 6:00 PM
    It definitely seems correct to me:
    Copy code
    class ThriftBinary(object):
  """Encapsulates access to pre-built thrift static binaries."""

  class Factory(Subsystem):
    options_scope = 'thrift-binary'

    @classmethod
    def dependencies(cls):
      return (BinaryUtil.Factory,)

    @classmethod
    def register_options(cls, register):
      register('--supportdir', recursive=True, advanced=True, default='bin/thrift',
               help='Find thrift binaries under this dir.   Used as part of the path to lookup the'
                    'tool with --binary-util-baseurls and --pants-bootstrapdir')
      register('--version', recursive=True, advanced=True, default='0.9.2',
               help='Thrift compiler version.   Used as part of the path to lookup the'
                    'tool with --binary-util-baseurls and --pants-bootstrapdir’)
  • e

    enough-analyst-54434

    07/29/2015, 6:00 PM
    I'm noodling twitter-commons, which I upgraded to 0.0.39 but kept back on thrift 0.5.0-finagle using this advice
  • m

    mammoth-autumn-2551

    07/29/2015, 6:03 PM
    hmm it seems to be working for me now after removing some redundant old config entries in gen.thrift
  • m

    mammoth-autumn-2551

    07/29/2015, 6:03 PM
    let me put them back and confirm that was the problem
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    gen.thrift should only affect java codegen
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    confusingly ... aha
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    So 0.0.39 still generates python thrift 2x
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    Once is logged and ... UNUSED
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    the other is done for real by the python toolchain silently
  • e

    enough-analyst-54434

    07/29/2015, 6:04 PM
    0.0.40 removes the confusing double gen
  • e

    enough-analyst-54434

    07/29/2015, 6:05 PM
    aka - the python log lines you see above are accurate, python stubs are being generated by the ApacheThriftGen task (not used by python toolchain), since you have that task ('gen.thrift') using its own thrift version
  • e

    enough-analyst-54434

    07/29/2015, 6:06 PM
    Its all too confusing, but confusion-fixed on master / by this week's 0.0.40 release - does this make any sense?
  • m

    mammoth-autumn-2551

    07/29/2015, 6:07 PM
    I think so… regardless I think I’m in a working condition now via pinning the version via config
  • m

    mammoth-autumn-2551

    07/29/2015, 6:07 PM
    Thanks again @enough-analyst-54434
1...888990...2420Latest