https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    07/29/2015, 5:14 PM
    we're close to bandwidth
  • w

    witty-crayon-22786

    07/29/2015, 5:14 PM
    but is there really nothing that can be done incrementally?
  • e

    enough-analyst-54434

    07/29/2015, 5:15 PM
    We can always do thing incrementally it just adds thrash
  • w

    witty-crayon-22786

    07/29/2015, 5:15 PM
    is there an idea of what the "final" Task api would look like?
  • e

    enough-analyst-54434

    07/29/2015, 5:16 PM
    Thats job in the interim - just whiteboard sketches from post-summit day
  • e

    enough-analyst-54434

    07/29/2015, 5:16 PM
    Between Ity, Patrick and I
  • e

    enough-analyst-54434

    07/29/2015, 5:17 PM
    Its sort-of been a killer that folks who care about this have not been around for the discussions - 3 instances, all bad timing!
  • e

    enough-analyst-54434

    07/29/2015, 5:18 PM
    ok @mammoth-autumn-2551 I'm having some difficulty getting pre-builts ready for 0.9.1, but to unblock you, you just need 1 bit of config, and possibly a second until I get static binaries built
  • e

    enough-analyst-54434

    07/29/2015, 5:20 PM
    ```ini[thrift-binary]
  • e

    enough-analyst-54434

    07/29/2015, 5:20 PM
    erm
  • e

    enough-analyst-54434

    07/29/2015, 5:20 PM
    [thrift-binary] version: 0.9.1
  • e

    enough-analyst-54434

    07/29/2015, 5:21 PM
    That's the only pants.ini change, but then you also need a static binary repo that has the thing, so you can wait for me a bit or else toss in your own URL to the list for:
  • e

    enough-analyst-54434

    07/29/2015, 5:22 PM
  • e

    enough-analyst-54434

    07/29/2015, 5:23 PM
    When I have the 0.9.1 build working for linux I'll do a bintray publish and ask you to run the build script for OSX like we did last time
  • e

    enough-analyst-54434

    07/29/2015, 5:28 PM
    And @mammoth-autumn-2551, if you want 0.9.2 for java gen you just also add 
    [thrift-binary.gen.thrift] version: 0.9.2
    to ensure the java apache thrift gen picks up 0.9.2 despite the global 0.9.1 setting
  • m

    mammoth-autumn-2551

    07/29/2015, 5:34 PM
    okay, sounds good
  • m

    mammoth-autumn-2551

    07/29/2015, 5:34 PM
    was java on 0.9.1 before as well?
  • m

    mammoth-autumn-2551

    07/29/2015, 5:34 PM
    I’m happy to just keep things stable and increment thrift version independent of pants upgrade
  • e

    enough-analyst-54434

    07/29/2015, 5:35 PM
    No - it was 0.5.0-finagle - a fork at a sha here: https://github.com/pantsbuild/thrift-0.5.0-finagle
  • e

    enough-analyst-54434

    07/29/2015, 5:35 PM
    In the deep past Marius was going to contribute the finagle extensions as a native --gen for apache thrift
  • e

    enough-analyst-54434

    07/29/2015, 5:35 PM
    But that never happened
  • m

    mammoth-autumn-2551

    07/29/2015, 5:37 PM
    oh yea we use that for java too
  • w

    witty-crayon-22786

    07/29/2015, 5:38 PM
    we've moved to scrooge in almost all cases
  • m

    mammoth-autumn-2551

    07/29/2015, 5:38 PM
    we have 
    [gen.thrift] version: 0.5.0-finagle
  • e

    enough-analyst-54434

    07/29/2015, 5:38 PM
    OK - and you're saying you do use the finagle extension bits in your services?
  • m

    mammoth-autumn-2551

    07/29/2015, 5:39 PM
    yes
  • e

    enough-analyst-54434

    07/29/2015, 5:39 PM
    K - then you're stuck unless you move to scrooge for the java/scala side
  • m

    mammoth-autumn-2551

    07/29/2015, 5:39 PM
    I’d like to move us to scrooge in the near future as well, but one thing at a time
  • e

    enough-analyst-54434

    07/29/2015, 5:39 PM
    OK - then you need to pin java back or both java and python back by just 
    [thrift-binary] version: 0.5.0-finagle
  • e

    enough-analyst-54434

    07/29/2015, 5:40 PM
    Then you're good to go for now
1...878889...2420Latest