#general
- e
enough-analyst-54434
07/28/2015, 9:42 PMalthough, the need to produce 'scala' is still there in several upstream consumers, so this is definitely in the full on hack the RoundEngine deficiences zone 😕 - e
enough-analyst-54434
07/28/2015, 9:43 PMSo ... Your approach sgtm with a comment about the hack going on - ie we need to ensure codegen comes before resolve and compile, which are the 2 bits looking for 'java' and 'scala' right now (...and idea/eclipse) - j
jolly-chef-92794
07/28/2015, 9:45 PMSo still put ['java','scala','python'] in the base-class, or in each of the leaves, but put ['scala','java'] wherever I would normally put ['java']? - e
enough-analyst-54434
07/28/2015, 10:16 PMJust the baseclass bit + comment would be fine I think - j
jolly-chef-92794
07/28/2015, 10:16 PMokay - e
enough-analyst-54434
07/28/2015, 10:17 PMFWIW - the reason pants is not bit is it installs the scrooge contrib - e
enough-analyst-54434
07/28/2015, 10:17 PMwhich provides 'java', 'scala' - j
jolly-chef-92794
07/28/2015, 10:17 PMahh - e
enough-analyst-54434
07/28/2015, 10:17 PMits just those 2 product types that are embroiled in the hacks - m
mammoth-autumn-2551
07/29/2015, 4:27 PM@enough-analyst-54434: after upgrading to 0.0.39… is there a straightforward configuration-only way to still use 0.9.1 thrift compiler in python? - m
mammoth-autumn-2551
07/29/2015, 4:27 PMWe have some code that is using thrift structs in sets, and 0.9.2 added a hash function that is less than happy - m
mammoth-autumn-2551
07/29/2015, 4:28 PMSaid code is probably a bad idea, but I’d like to get this upgrade out the door - e
enough-analyst-54434
07/29/2015, 4:29 PMYesish - from my phone, be online shortly to explain. - m
mammoth-autumn-2551
07/29/2015, 4:30 PMThanks, don’t rush! I’m gonna jet to lunch anyways @enough-analyst-54434 - m
mammoth-pharmacist-54215
07/29/2015, 4:45 PMI’ve been working on a style checker for python based on the style checker that is currently in twitter.commons. I was hoping to get some feedback on a couple points. - m
mammoth-pharmacist-54215
07/29/2015, 4:45 PMRight now I plan on having it run as a task off of pytest, and by default I plan on having it do nothing unless you enable plugins. This way I don’t break anyone. - m
mammoth-pharmacist-54215
07/29/2015, 4:46 PMdoes that seem like sane default behavior? - m
mammoth-pharmacist-54215
07/29/2015, 4:47 PMMy other question is should I create a separate task for each plugin or one style checker task that uses a bunch of plugins. The main reason I started using the plugin model is that is how it was done in twitter.common but I could see advantages to doing them as separate tasks. - e
enough-analyst-54434
07/29/2015, 4:47 PMMaybe, but its different from current behavior for other style checkers - e
enough-analyst-54434
07/29/2015, 4:47 PMThey always run, but only if installed - e
enough-analyst-54434
07/29/2015, 4:48 PMPants installs them for itself here: https://github.com/pantsbuild/pants/blob/master/pants-plugins/src/python/internal_backend/optional/register.py - m
mammoth-pharmacist-54215
07/29/2015, 4:48 PManother option is I could have them run in a non failing way… this way it displays the output but doesn’t “fail” the test. - e
enough-analyst-54434
07/29/2015, 4:49 PMTrue - although , again different from scalastyle and checkstyle - e
enough-analyst-54434
07/29/2015, 4:49 PMI think it makes sense to have consistent style check plugins in installation method and behavior - e
enough-analyst-54434
07/29/2015, 4:49 PMSo, fix em all, or go with the flow would be my vote - m
mammoth-pharmacist-54215
07/29/2015, 4:50 PMwhen someone uses a pants.pex for example how do they register optional checkers? - e
enough-analyst-54434
07/29/2015, 4:50 PMjust like the link I showed - e
enough-analyst-54434
07/29/2015, 4:50 PMYou write a register.py😮 2 - e
enough-analyst-54434
07/29/2015, 4:50 PMand list it in your pants.ini pythonpath and backends: - m
mammoth-pharmacist-54215
07/29/2015, 4:50 PMperfect, thanks