https://pantsbuild.org/ logo
Powered by
#general
  • r

    rough-minister-58256

    07/24/2015, 6:09 PM
    btw, thanks for fixing that up @enough-analyst-54434 - good stuff.
  • a

    astonishing-jelly-60479

    07/24/2015, 6:09 PM
    yesssssss thank you
  • e

    enough-analyst-54434

    07/24/2015, 6:11 PM
    You're both welcome - that was a big bug, so thanks for finding it @astonishing-jelly-60479
  • e

    enough-analyst-54434

    07/24/2015, 6:11 PM
    Now to go stop ApacheThriftGen from generating python stubs at all
  • w

    witty-crayon-22786

    07/24/2015, 6:16 PM
    @enough-analyst-54434: just so we're crystal, what was the review/sha you wanted in?
  • e

    enough-analyst-54434

    07/24/2015, 6:16 PM
  • w

    witty-crayon-22786

    07/24/2015, 6:16 PM
    thanks much
  • e

    enough-analyst-54434

    07/24/2015, 6:18 PM
    I mentioned it to Kris yesterday, but you'll also get burned by this one, which is less easy to pull in right now: https://rbcommons.com/s/twitter/r/2517/
  • e

    enough-analyst-54434

    07/24/2015, 6:18 PM
    If you have any non zip_safe python targets
  • e

    enough-analyst-54434

    07/24/2015, 6:19 PM
    If you can walk over to wickman and give him a pair of new colorful socks, it might grease the wheels
  • r

    rough-minister-58256

    07/24/2015, 6:20 PM
    I asked him about it yesterday, he said he’d take a look
  • r

    rough-minister-58256

    07/24/2015, 6:20 PM
    haha @ socks
  • e

    enough-analyst-54434

    07/24/2015, 6:21 PM
    It all connects to the pants somehow, someway
  • j

    jolly-chef-92794

    07/24/2015, 6:58 PM
    What's the preferred way to access the logging system from a Subsystem, since 
    context
    isn't available?
  • e

    enough-analyst-54434

    07/24/2015, 6:59 PM
    plain old logger
  • e

    enough-analyst-54434

    07/24/2015, 7:00 PM
  • j

    jolly-chef-92794

    07/24/2015, 7:01 PM
    okay
  • j

    jolly-chef-92794

    07/24/2015, 7:01 PM
    thanks
  • a

    ancient-stone-50795

    07/24/2015, 7:05 PM
  • h

    happy-kitchen-89482

    07/24/2015, 7:30 PM
    @jolly-chef-92794: We want to switch everything over to plain old logger at some point.
  • h

    happy-kitchen-89482

    07/24/2015, 7:31 PM
    If we repoint context.log to that, and everything works, then it's a mechanical change after that.
  • a

    ancient-stone-50795

    07/24/2015, 8:37 PM
    I’m about to merge the changelog and publish 0.0.39
    🍶 1
  • e

    enough-analyst-54434

    07/24/2015, 8:39 PM
    Thanks Eric
  • r

    rough-minister-58256

    07/24/2015, 8:42 PM
    🎉
  • a

    ancient-stone-50795

    07/24/2015, 8:45 PM
    🎉 👖 🎉
  • a

    ancient-stone-50795

    07/24/2015, 8:49 PM
    The release is running. I just realized I forgot to run contributors.sh… and we have 2 new contributors to list: Matt Olsen and Luc Cary
  • a

    ancient-stone-50795

    07/24/2015, 8:50 PM
    I will give them props in the release notice
  • e

    enough-analyst-54434

    07/24/2015, 8:53 PM
    SG - I don't think its a big deal to follow up with an RB for that just after the release finishes.
  • a

    ancient-stone-50795

    07/24/2015, 9:12 PM
    Hm. hope I didn’t break the build. I submitted that one without letting the PR finish.
  • a

    ancient-stone-50795

    07/24/2015, 9:12 PM
    (the contributor change).
1...808182...2420Latest