https://pantsbuild.org/ logo
Powered by
#general
  • a

    astonishing-jelly-60479

    07/23/2015, 7:34 PM
  • e

    enough-analyst-54434

    07/23/2015, 7:34 PM
    That does not generate your python thrift
  • a

    astonishing-jelly-60479

    07/23/2015, 7:34 PM
    the ttypes.py file—that is there, even though it's basically empty—doesn't get included int he chroot
  • e

    enough-analyst-54434

    07/23/2015, 7:34 PM
    its a sad confusing tale
  • e

    enough-analyst-54434

    07/23/2015, 7:34 PM
    This generates your python...:
  • e

    enough-analyst-54434

    07/23/2015, 7:35 PM
  • a

    astonishing-jelly-60479

    07/23/2015, 7:36 PM
    what's the right way to build a .pex from a python_binary target, ./pants binary?
  • e

    enough-analyst-54434

    07/23/2015, 7:36 PM
    yup
  • a

    astonishing-jelly-60479

    07/23/2015, 7:36 PM
    then this code is definitely being hit during the compile/python-eval/eval-targets phase
  • a

    astonishing-jelly-60479

    07/23/2015, 7:37 PM
    and the resultant chroot doesn't contain the files that aren't listed because they're not yielded from that function
  • a

    astonishing-jelly-60479

    07/23/2015, 7:37 PM
    i believe you if that's not what's actually generating a .pex
  • a

    astonishing-jelly-60479

    07/23/2015, 7:37 PM
    but it never even gets past the compile phase
  • e

    enough-analyst-54434

    07/23/2015, 7:37 PM
    ok
  • e

    enough-analyst-54434

    07/23/2015, 7:38 PM
    Are the thrift files something you could minimize and provide on a branch somewhere?
  • b

    bored-art-40741

    07/23/2015, 7:39 PM
    Are the files completely missing, or is it possible that there's a missing 
    __init__.py
    in the path to the ttypes file?
  • a

    astonishing-jelly-60479

    07/23/2015, 7:39 PM
    yeah, i could try and construct a test case
  • a

    astonishing-jelly-60479

    07/23/2015, 7:39 PM
    completely missing
  • b

    bored-art-40741

    07/23/2015, 7:39 PM
    I suspect apache thrift gen is hit but its results are thrown away
  • a

    astonishing-jelly-60479

    07/23/2015, 7:39 PM
    yes
  • b

    bored-art-40741

    07/23/2015, 7:39 PM
    As John said, sad and confusing
  • r

    rough-minister-58256

    07/23/2015, 7:40 PM
    @astonishing-jelly-60479: you’re getting an importerror on ttypes?
  • r

    rough-minister-58256

    07/23/2015, 7:40 PM
    we’re seeing that too.
  • a

    astonishing-jelly-60479

    07/23/2015, 7:40 PM
    yeah
  • r

    rough-minister-58256

    07/23/2015, 7:40 PM
    from what I can tell, inside your pex you’ll find two copies of the thriftgen’d code
  • r

    rough-minister-58256

    07/23/2015, 7:40 PM
    one in a wheel, one in ./gen
  • r

    rough-minister-58256

    07/23/2015, 7:41 PM
    this seems to be true for old copies of pants too, however with pex 1.x the path in ./gen gets loaded prior to the wheel
  • e

    enough-analyst-54434

    07/23/2015, 7:41 PM
    what versions / shas are you each on?
  • a

    astonishing-jelly-60479

    07/23/2015, 7:41 PM
    trying to upgrade to 0.0.38
  • r

    rough-minister-58256

    07/23/2015, 7:42 PM
    so basically, old problem where thrift is getting duplicated but now throwing errors due to the order in which pex imports
  • a

    astonishing-jelly-60479

    07/23/2015, 7:42 PM
    from a... very old version
1...757677...2420Latest