pantsbuild #general

Channels

welcome

github-notifications

announce

mammoth-pharmacist-54215

07/21/2015, 9:52 PM

okay, I'll test to verify that is the case, thanks

glamorous-carpenter-79

07/22/2015, 12:32 AM

hello, adding up lessc binary files. To add a binary in https://dl.bintray.com/pantsbuild/bin/build-support/bin/ i need to push it to https://github.com/pantsbuild/binaries/tree/gh-pages/build-support/bin

enough-analyst-54434

07/22/2015, 12:34 AM

Correct. Then run the sync script. Preferrably, you also add a build-lessc.sh script and create x86_64 and i386 versions using the vagrant vm

enough-analyst-54434

07/22/2015, 12:35 AM

Actually, Eric or I have to run the sync script - IIRC we're the only 2 folks with perms on bintray

enough-analyst-54434

07/22/2015, 12:35 AM

But you can do the github commits and ping us when its all looking good

glamorous-carpenter-79

07/22/2015, 12:35 AM

ok will do . thx!

enough-analyst-54434

07/22/2015, 12:37 AM

Take a look at the thrift or protoc scripts - the biggest deal is to get the full static binary bit right

enough-analyst-54434

07/22/2015, 12:37 AM

We had that wrong for a very long time

witty-crayon-22786

07/22/2015, 2:01 AM

http://stackoverflow.com/questions/2295290/what-do-lambda-function-closures-capture-in-python

witty-crayon-22786

07/22/2015, 2:01 AM

enough-analyst-54434

07/22/2015, 2:04 AM

completey consistent though with pythons scoping of locals in a function

enough-analyst-54434

07/22/2015, 2:04 AM

its that bit which is weird and you must internalize no matter how much you hate it

witty-crayon-22786

07/22/2015, 2:26 AM

certainly makes futures-based code stranger

enough-analyst-54434

07/22/2015, 2:29 AM

only if you consider a small local function (instead of a lambda) strange

enough-analyst-54434

07/22/2015, 2:32 AM

For some things, its convenient to think of contextmanagers as a way to pass a block, and that makes syntax "nicer" depending - ie: if you need just 1 block you can restructure your function as a contextmanager and yield to a block

enough-analyst-54434

07/22/2015, 2:33 AM

but I think sucking it up and using local functions is usually the right thing to do at the expense of an ugly judgement, too much typing, what have you

witty-crayon-22786

07/22/2015, 2:33 AM

yea, true.

witty-crayon-22786

07/22/2015, 2:34 AM

in this case i was able to use partial

witty-crayon-22786

07/22/2015, 2:34 AM

...since the called method was already on the class

witty-crayon-22786

07/22/2015, 2:35 AM

@enough-analyst-54434: if you haven't, it's really worth spending some time to grok futures... particularly finagle/scala's, which facebook cloned for c++ here: https://code.facebook.com/posts/1661982097368498

enough-analyst-54434

07/22/2015, 2:36 AM

I grok'em

enough-analyst-54434

07/22/2015, 2:36 AM

You're error here in python is maybe expecting their futures, modeled like java's - to be what they are not

witty-crayon-22786

07/22/2015, 2:37 AM

ah, damn. haven't looked at python's =(

enough-analyst-54434

07/22/2015, 2:37 AM

== java's

witty-crayon-22786

07/22/2015, 2:37 AM

yea.

enough-analyst-54434

07/22/2015, 2:37 AM

not composable, just a deferred value

enough-analyst-54434

07/22/2015, 2:38 AM

well, out of the box anyway

witty-crayon-22786

07/22/2015, 2:38 AM

still useful for the "do N things in parallel and get the results of all actions" and "do N things and get the first to return" type cases

enough-analyst-54434

07/22/2015, 2:38 AM

yeah - which is about all we'll need

witty-crayon-22786

07/22/2015, 2:38 AM

i've been using a minimum-viable promise for some internal tasks