https://pantsbuild.org/ logo
Powered by
#general
  • m

    many-engine-77019

    11/03/2015, 12:41 AM
    is there really value in running this locally when we have travis?
  • e

    enough-analyst-54434

    11/03/2015, 12:41 AM
    I think Compass counts, Ugo is an Italio-Jew IIUC
  • s

    stocky-salesmen-83101

    11/03/2015, 12:41 AM
    compass?
  • m

    many-engine-77019

    11/03/2015, 12:41 AM
    or should I just remove that from the contributor guide
  • e

    enough-analyst-54434

    11/03/2015, 12:41 AM
    Urban Compass - NY real estate
  • m

    mysterious-action-44812

    11/03/2015, 12:41 AM
    @salmon-summer-38098: @stocky-salesmen-83101 If you know anyone good in NY point them my way :). Im behind with my cofounder he's hiring Greeks faster than I am Israelis
  • s

    stocky-salesmen-83101

    11/03/2015, 12:41 AM
    ah
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:41 AM
    @many-engine-77019: I usually like to at least run the targeted tests because travis is slow enough for everyone as it is.
  • e

    enough-analyst-54434

    11/03/2015, 12:41 AM
    Ugo was a ... NY office founder
  • e

    enough-analyst-54434

    11/03/2015, 12:41 AM
    Forget their name
  • s

    stocky-salesmen-83101

    11/03/2015, 12:41 AM
    @mysterious-action-44812
  • s

    stocky-salesmen-83101

    11/03/2015, 12:41 AM
    where are you based?
  • m

    many-engine-77019

    11/03/2015, 12:42 AM
    @mammoth-pharmacist-54215: doesn’t github already run them all anyway?
  • m

    many-engine-77019

    11/03/2015, 12:42 AM
    I mean github kicks off a travis build
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:42 AM
    yeah
  • e

    enough-analyst-54434

    11/03/2015, 12:42 AM
    @many-engine-77019: yes
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:42 AM
    but they take up resources
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:42 AM
    so I try to make sure its going to pass before I push to my remote branch
  • m

    many-engine-77019

    11/03/2015, 12:43 AM
    ah
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:43 AM
    its more of a good citizen thing than a code quality issue.
  • r

    rough-minister-58256

    11/03/2015, 12:43 AM
    we’re on the OSS plan which is basically 1 concurrent job at a time 😞
  • m

    many-engine-77019

    11/03/2015, 12:43 AM
    so perhaps that should be moved earlier in the instructions, but if my travis build has already passed, forget it
  • e

    enough-analyst-54434

    11/03/2015, 12:43 AM
    You should generally have a clue about which tests are relevant, but someties its hard, you can always 
    ./pants test-changed
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:44 AM
    if your tests have a large impact like changes to the options system or something its nice to get the integration tests to run though.
  • m

    many-engine-77019

    11/03/2015, 12:44 AM
  • m

    many-engine-77019

    11/03/2015, 12:45 AM
    which I guess I’m not a committer anyway so uh
  • m

    many-engine-77019

    11/03/2015, 12:45 AM
    volunteers? simple smile
  • r

    rough-minister-58256

    11/03/2015, 12:46 AM
    PRs welcome 😉
  • m

    many-engine-77019

    11/03/2015, 12:46 AM
  • m

    mammoth-pharmacist-54215

    11/03/2015, 12:46 AM
    no one has flipped my switch on commiter status
1...664665666...2420Latest