https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    11/02/2015, 8:34 PM
    So no need to namespace
  • e

    enough-analyst-54434

    11/02/2015, 8:34 PM
    If thats what you're getting at
  • b

    bright-dinner-81701

    11/02/2015, 8:38 PM
    yeah
  • b

    bright-dinner-81701

    11/02/2015, 8:38 PM
    i just assumed i should bc the others did that
  • b

    bright-dinner-81701

    11/02/2015, 8:38 PM
    - $HOME/.cache/pants - $HOME/.ivy2/pants
  • e

    enough-analyst-54434

    11/02/2015, 8:40 PM
    We probably should going forward, for the stability fix I'll just cache the current ~/.npm/ and a later RB can fix NpmResolve to explicitly control the cache dir
  • b

    bright-dinner-81701

    11/02/2015, 8:40 PM
    ok
  • b

    bright-dinner-81701

    11/02/2015, 8:41 PM
  • e

    enough-analyst-54434

    11/02/2015, 8:42 PM
    Yeah - I'm pretty sure my early resolve dabbling turned up npm switches to set this per install, pants could just always pass the switch
  • b

    bright-dinner-81701

    11/02/2015, 8:56 PM
    should i open a PR or are you adding the line?
  • e

    enough-analyst-54434

    11/02/2015, 9:01 PM
    I am
  • b

    bright-dinner-81701

    11/02/2015, 9:17 PM
    ok thanks
  • h

    happy-kitchen-89482

    11/02/2015, 10:57 PM
    Someone at twitter: Can you run this thing for me? 
    find path/to/your/custom/pants/plugins -type f | xargs  grep -o -E "action='[a-z_]+'" | sort | uniq
  • h

    happy-kitchen-89482

    11/02/2015, 10:57 PM
    Ditto someone at square?
  • b

    bored-art-40741

    11/02/2015, 10:58 PM
    Don't forget whitespace around the 
    =
  • w

    witty-crayon-22786

    11/02/2015, 10:59 PM
    @happy-kitchen-89482: presumably with 
    -h
    on the grep?
  • w

    witty-crayon-22786

    11/02/2015, 10:59 PM
    Copy code
    $ find pants-plugins -type f | xargs  grep -h -o -E "action='[a-z_]+'" | sort | uniq
action='append'
action='store'
action='store_true'
  • h

    happy-kitchen-89482

    11/02/2015, 10:59 PM
    Oh, I have -h on by default via a bash alias
  • h

    happy-kitchen-89482

    11/02/2015, 10:59 PM
    but yes
  • h

    happy-kitchen-89482

    11/02/2015, 10:59 PM
    thanks
  • w

    witty-crayon-22786

    11/02/2015, 10:59 PM
    Copy code
    $ find pants-plugins -type f | xargs  grep -h -o -E "action='[a-z_]+'" | sort | uniq -c
   8 action='append'
   3 action='store'
  21 action='store_true'
  • h

    happy-kitchen-89482

    11/02/2015, 10:59 PM
    Just double-checking that we don't use anything funky
  • h

    happy-kitchen-89482

    11/02/2015, 10:59 PM
    we don't intend to support anything other than append, store, store_true and store_false, but who knows...
  • w

    witty-crayon-22786

    11/02/2015, 11:50 PM
    @enough-analyst-54434: so @rough-minister-58256 has a fair count of backlogged reviews for the daemon stuff
  • w

    witty-crayon-22786

    11/02/2015, 11:51 PM
    it sounds like it is up-to-and-including some caching of the buildgraph (which i didn't realize... thought that part was still in progress)
  • e

    enough-analyst-54434

    11/02/2015, 11:51 PM
    Ok
  • w

    witty-crayon-22786

    11/02/2015, 11:51 PM
    in order to focus on the engine refactor, i'd like to draw a line in the sand on that stuff
  • w

    witty-crayon-22786

    11/02/2015, 11:51 PM
    and figure out how much he should focus on landing before he switches to engine work
  • w

    witty-crayon-22786

    11/02/2015, 11:52 PM
    @rough-minister-58256: based on what we talked about, do you think "caching of backend and options loading" exists in the branch and is a good place to stop for now?
  • w

    witty-crayon-22786

    11/02/2015, 11:53 PM
    or is there some other line we should draw
1...659660661...2420Latest