https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    10/23/2015, 7:58 PM
    I'm going to start it, anyway
  • m

    many-doctor-21484

    10/23/2015, 8:30 PM
    anyone can help ship this? https://rbcommons.com/s/twitter/r/3012/
  • h

    happy-kitchen-89482

    10/23/2015, 8:32 PM
    Show of hands: Can I get rid of the options system feature that allows shadowing of options from outer scopes in inner scopes?
  • h

    happy-kitchen-89482

    10/23/2015, 8:33 PM
    E.g., if an outer scope registers an option 
    [-f, --foo]
    , then an inner scope can re-register 
    -f
    or 
    --foo
    , or both, to unrelated options.
  • h

    happy-kitchen-89482

    10/23/2015, 8:33 PM
    We don't actually do this anywhere
  • h

    happy-kitchen-89482

    10/23/2015, 8:33 PM
    and it might be a bad idea to do so
  • h

    happy-kitchen-89482

    10/23/2015, 8:33 PM
    And supporting this adds unnecessary complication
  • h

    happy-kitchen-89482

    10/23/2015, 8:34 PM
    Anyone care for this feature and want to speak up for it?
  • w

    witty-crayon-22786

    10/23/2015, 8:52 PM
    @happy-kitchen-89482: would be good to kill it, yea. in the long run, the ability for subscopes to override a default would be awesome, but shadowing would be a terrible way to accomplish that.
  • w

    witty-crayon-22786

    10/23/2015, 8:53 PM
    we don't shadow as far as i know
  • h

    happy-kitchen-89482

    10/23/2015, 8:53 PM
    well subscopes can override the value of an outer-scope option if it's registered with recursive=True
  • h

    happy-kitchen-89482

    10/23/2015, 8:53 PM
    that's orthogonal
  • h

    happy-kitchen-89482

    10/23/2015, 8:53 PM
    the feature I want to kill is the ability to re-register an existing name to a totally unrelated option
  • h

    happy-kitchen-89482

    10/23/2015, 8:53 PM
    That seems like a recipe for confusion
  • w

    witty-crayon-22786

    10/23/2015, 8:54 PM
    hm. so basically "fail if recursive=False"?
  • w

    witty-crayon-22786

    10/23/2015, 8:56 PM
    @bored-art-40741: sorry, was at lunch... can you get in https://rbcommons.com/s/twitter/r/3028/ ?
  • w

    witty-crayon-22786

    10/23/2015, 8:57 PM
    i'll merge it now if so, or you can
  • b

    bored-art-40741

    10/23/2015, 9:21 PM
    I haven't finished the prep commit yet
  • b

    bored-art-40741

    10/23/2015, 9:21 PM
    lmk when it goes upstream, assuming it's reviewed and passes CI
  • b

    bored-art-40741

    10/23/2015, 9:29 PM
    urgh why did everyone work so hard on pants this week
  • b

    bored-art-40741

    10/23/2015, 9:37 PM
    CR is up for the release: https://rbcommons.com/s/twitter/r/3031/
  • b

    bored-art-40741

    10/23/2015, 9:37 PM
    @witty-crayon-22786: I'll wait for your fix to go upstream and then rebase, update, and release after CI is green
  • w

    witty-crayon-22786

    10/23/2015, 9:59 PM
    oh, sorry... merging
  • h

    happy-kitchen-89482

    10/23/2015, 10:01 PM
    Note that I will also be removing the (unused) feature of options with multiple args (e.g., '-f', '--foo') being accessible from both names (options.f and options.foo)
  • h

    happy-kitchen-89482

    10/23/2015, 10:01 PM
    We have almost no such options anyway
  • h

    happy-kitchen-89482

    10/23/2015, 10:01 PM
    from now on all access will be via the canonical 'dest'
  • h

    happy-kitchen-89482

    10/23/2015, 10:01 PM
    options.foo in this case
  • w

    witty-crayon-22786

    10/23/2015, 10:07 PM
    @bored-art-40741: merged; sorry for the wait
  • b

    bored-art-40741

    10/23/2015, 10:08 PM
    np
  • b

    bored-art-40741

    10/23/2015, 10:10 PM
    @witty-crayon-22786: Done https://rbcommons.com/s/twitter/r/3031/
1...630631632...2420Latest