https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    10/22/2015, 9:33 PM
    It uses our internal python import linter + sorter + unused import remover
  • b

    bored-art-40741

    10/22/2015, 9:33 PM
    When I get a chance I'll get it into contrib
  • b

    bored-art-40741

    10/22/2015, 9:34 PM
    OSS pants could definitely use this at the very least to ensure no missing/unneeded deps and to fix unused imports
  • r

    rough-minister-58256

    10/22/2015, 9:35 PM
    checkstyle will catch unused imports
  • r

    rough-minister-58256

    10/22/2015, 9:35 PM
    matt removed a bunch of them early on
  • b

    bored-art-40741

    10/22/2015, 9:35 PM
    Oh that's good
  • r

    rough-minister-58256

    10/22/2015, 9:37 PM
    Patrick are you here next wednesday?
  • b

    bored-art-40741

    10/22/2015, 9:38 PM
    Yup!
  • r

    rough-minister-58256

    10/22/2015, 9:38 PM
    sweet
  • r

    rough-minister-58256

    10/22/2015, 9:39 PM
    would love to see a demo of buildgen4py
  • r

    rough-minister-58256

    10/22/2015, 9:39 PM
    and chat a bit more about your guys experience with whls/vend
  • b

    bored-art-40741

    10/22/2015, 9:39 PM
    vend actually a stalled a bit because of pip dragging their heels. I should get back to finishing it eventually
  • b

    bored-art-40741

    10/22/2015, 9:40 PM
    Right now we use the original version, 
    vex
  • b

    bored-art-40741

    10/22/2015, 9:40 PM
    It's less featureful (i.e. not an executable zipfile, no fancy venv caching on the target machine), but it's the same principle
  • r

    rough-minister-58256

    10/22/2015, 9:42 PM
    we’re considering moving from a model of declaring dependency specs (e.g. ‘psutil==3.2.1’) to declaring direct files (e.g. 'http://xyz/psutil-3.2.1-linux-x86_64.whl') and using tooling to resolve at BUILD modificaiton time vs resolution-per-build. I think you guys have thought about this if not already doing something like it.
  • w

    witty-crayon-22786

    10/22/2015, 10:08 PM
    @enough-analyst-54434: thinking of changing 
    transitive=Bool
    to 
    walk=[self,direct,transitive]
    in 
    classpath_products
    and 
    classpath_util
    . rip the bandaid off?
  • e

    enough-analyst-54434

    10/22/2015, 10:09 PM
    I don;t get the difference between self and direct
  • w

    witty-crayon-22786

    10/22/2015, 10:10 PM
    direct is directly declared deps
  • w

    witty-crayon-22786

    10/22/2015, 10:10 PM
    self is just yourself
  • w

    witty-crayon-22786

    10/22/2015, 10:10 PM
    (names!)
  • e

    enough-analyst-54434

    10/22/2015, 10:11 PM
    still don't get it - what are java_library1's self deps and direct deps given it deps on jar1, jar2, target3 ?
  • w

    witty-crayon-22786

    10/22/2015, 10:11 PM
    java_library1's self dep is java_library1
  • w

    witty-crayon-22786

    10/22/2015, 10:11 PM
    java_library1's direct deps are java_library1, jar1, jar2, target3
  • e

    enough-analyst-54434

    10/22/2015, 10:11 PM
    I don't understand the utility of the self dep
  • w

    witty-crayon-22786

    10/22/2015, 10:11 PM
    in the context of a classpath, it's what we currently use 
    transitive=False
    for.
  • w

    witty-crayon-22786

    10/22/2015, 10:12 PM
    transitive=False == self
  • w

    witty-crayon-22786

    10/22/2015, 10:12 PM
    transitive=True == transitive
  • e

    enough-analyst-54434

    10/22/2015, 10:12 PM
    I kinda have no clue - you have more of a clue what you're after here
  • w

    witty-crayon-22786

    10/22/2015, 10:12 PM
    ?? == direct
  • e

    enough-analyst-54434

    10/22/2015, 10:12 PM
    go for it
1...582583584...2420Latest