https://pantsbuild.org/ logo
Powered by
#general
  • a

    ancient-stone-50795

    10/16/2015, 5:25 PM
    @no, we aren’t. I created a github issue to cull that out of simple_codegen_task.py: https://github.com/pantsbuild/pants/issues/2337
  • w

    witty-crayon-22786

    10/16/2015, 5:26 PM
    ah, nice. i might tackle that, because i think it blocks our next release.
  • w

    witty-crayon-22786

    10/16/2015, 5:26 PM
    might/will.
  • w

    witty-crayon-22786

    10/16/2015, 7:26 PM
    @ancient-stone-50795: hm... do we need a deprecation cycle on global?
  • w

    witty-crayon-22786

    10/16/2015, 7:28 PM
    i might take the middle ground of: break global immediately, but provide deprecation for the removal of "strategies" in general.
  • a

    ancient-stone-50795

    10/16/2015, 7:29 PM
    @witty-crayon-22786: I don’t think so. Maybe just deprecate the options for a few rounds but go ahead and strip out the functionality?
  • w

    witty-crayon-22786

    10/16/2015, 7:29 PM
    sure.
  • w

    witty-crayon-22786

    10/16/2015, 7:30 PM
    ...hm. there actually aren't any user facing options. this is all internal.
  • w

    witty-crayon-22786

    10/16/2015, 7:30 PM
    oh, lies.
  • b

    bored-art-40741

    10/16/2015, 8:24 PM
    Heads up I am doing today's deploy since John covered for me while I was on vacation
  • b

    bored-art-40741

    10/16/2015, 8:24 PM
    I'll be starting that presently
  • b

    bored-art-40741

    10/16/2015, 8:24 PM
    If there are any late-breaking patches anyone wants to get in, let me know soon!
  • w

    witty-crayon-22786

    10/16/2015, 8:27 PM
    nothing that you can afford to wait for, although i might want to do a hotfix post https://github.com/pantsbuild/pants/issues/2337
  • l

    limited-terabyte-34878

    10/16/2015, 8:33 PM
    hello pants folks. Looks like there is a problem with my timeouts. If a test takes too long, the timeout is triggered and it fails, but it still runs — ie it isn’t aborted.
  • l

    limited-terabyte-34878

    10/16/2015, 8:33 PM
    i have figured out how to deal with this in python, but not java yet
  • l

    limited-terabyte-34878

    10/16/2015, 8:34 PM
    would love some feedback on this rb
  • l

    limited-terabyte-34878

    10/16/2015, 8:34 PM
  • b

    bored-art-40741

    10/16/2015, 9:00 PM
  • h

    happy-kitchen-89482

    10/16/2015, 9:10 PM
    @enough-analyst-54434: my SourceRoots reworking impinges on go_buildgen.py, so I have a couple of questions about that.
  • b

    bored-art-40741

    10/16/2015, 9:11 PM
    What do we want to do about this deprecation issue?
  • b

    bored-art-40741

    10/16/2015, 9:11 PM
    Is it on me to nuke these methods?
  • w

    witty-crayon-22786

    10/16/2015, 9:12 PM
    mm, yea... it's time
  • w

    witty-crayon-22786

    10/16/2015, 9:18 PM
    @bored-art-40741: we're on hold for merges, yea?
  • p

    proud-alligator-68508

    10/16/2015, 9:24 PM
    Are there any turndown steps for a no-longer-active committer (ie me)?
  • b

    bored-art-40741

    10/16/2015, 9:25 PM
    @witty-crayon-22786: well, at the very least we need to figure out the deprecations
  • h

    happy-kitchen-89482

    10/16/2015, 10:24 PM
    @bored-art-40741: Killed my CR until you get the release passing
  • b

    bored-art-40741

    10/16/2015, 10:27 PM
    So peanut gallery: should I bump the version of the deprecated methods, should I delete them in this review, or should I railroad through a CR to get rid of them?
  • b

    bored-art-40741

    10/16/2015, 10:27 PM
    I'm going to start on the latter unless I hear otherwise
  • b

    bored-art-40741

    10/16/2015, 10:28 PM
    Actually
  • b

    bored-art-40741

    10/16/2015, 10:28 PM
    It seems appropriate to couple the release commit itself exactly to the deletion of the deprecated methods
1...562563564...2420Latest