https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    10/15/2015, 11:20 PM
    Which also means more than likely having experienced devs on the review
  • b

    bored-art-40741

    10/15/2015, 11:21 PM
    But that shouldn't exclude non-committers from being able to review
  • b

    bored-art-40741

    10/15/2015, 11:21 PM
    (or be elected to review, anyway)
  • b

    bored-art-40741

    10/15/2015, 11:21 PM
    Though to be clear, I don't actually know how this works
  • w

    witty-crayon-22786

    10/15/2015, 11:21 PM
    ok. i actually just didn't know that's how it was... we have a section on posting reviews, but not on reviewing.
  • b

    bored-art-40741

    10/15/2015, 11:21 PM
    let me double check
  • b

    bored-art-40741

    10/15/2015, 11:22 PM
    Yeah AFAICT there's a magic bit which causes people to not show up in the 
    People
    section of Reviewers
  • b

    bored-art-40741

    10/15/2015, 11:22 PM
    Even if they have accounts, have submitted patches, etc
  • w

    witty-crayon-22786

    10/15/2015, 11:24 PM
    yea, which it should... have to be marked
  • w

    witty-crayon-22786

    10/15/2015, 11:24 PM
    well, in any case: if we should be marking everyone, i'm happy to add a section to the docs about that
  • w

    witty-crayon-22786

    10/15/2015, 11:25 PM
    would be good to confirm though. cc @happy-kitchen-89482 , @ancient-stone-50795 , @enough-analyst-54434
  • b

    bored-art-40741

    10/15/2015, 11:25 PM
    Agreed
  • b

    bored-art-40741

    10/15/2015, 11:25 PM
    I don't think being marked connotes any privileges other than being able to be flagged as a reviewer
  • e

    enough-analyst-54434

    10/15/2015, 11:28 PM
    The problem is RB is $$$ limited team memebers, the result is the hack of controlling RBCOMMONS twitter team membership via github comic ter rights
  • a

    ancient-stone-50795

    10/15/2015, 11:28 PM
    I think there is a sticky point in thatt to be a reviewer you have….what John said
  • a

    ancient-stone-50795

    10/15/2015, 11:28 PM
    I still have my coke
  • w

    witty-crayon-22786

    10/15/2015, 11:29 PM
    aha.
  • b

    bored-art-40741

    10/15/2015, 11:29 PM
    ah, okay
  • b

    bored-art-40741

    10/15/2015, 11:29 PM
    whelp
  • w

    witty-crayon-22786

    10/15/2015, 11:30 PM
    @cuddly-architect-27013: want to add a section about that ^ to http://pantsbuild.github.io/dev.html to bump your commit count?
  • b

    bored-art-40741

    10/15/2015, 11:30 PM
    I guess there's a long term question: how many committers do we expect to have?
  • e

    enough-analyst-54434

    10/15/2015, 11:31 PM
    When there are enough to blow the RBCommons account we apply to Apache? I'd be a fan of that
  • e

    enough-analyst-54434

    10/15/2015, 11:32 PM
    I just /cc @person in Github
  • e

    enough-analyst-54434

    10/15/2015, 11:32 PM
    Seems to work well enough to get their attention to review
  • e

    enough-analyst-54434

    10/15/2015, 11:33 PM
    That's all this is about - getting attention... afaict
  • e

    enough-analyst-54434

    10/15/2015, 11:33 PM
    Anyone can review, only People are notified by RBCommons
  • b

    bored-art-40741

    10/15/2015, 11:33 PM
    But then we have a bit of a split review process, which is annoying
  • b

    bored-art-40741

    10/15/2015, 11:33 PM
    I treat github as strictly a venue for triggering CI
  • e

    enough-analyst-54434

    10/15/2015, 11:33 PM
    Not really - my /cc is to review the RB
  • e

    enough-analyst-54434

    10/15/2015, 11:33 PM
    I do not accept github reviews
1...555556557...2420Latest