#general
- h
happy-kitchen-89482
10/15/2015, 7:38 PMMaybe we don't need a trie at all in this case - h
happy-kitchen-89482
10/15/2015, 7:38 PMWe'd have so few patterns to match, we could just iterate and regex them - h
happy-kitchen-89482
10/15/2015, 7:39 PMWe couldn't then support hundreds of fixed source roots, but I'm OK with that - h
happy-kitchen-89482
10/15/2015, 7:39 PMif you have hundreds of source roots AND they don't conform to a handful of patterns, then I'm comfortable crossing that bridge when we come to it... - w
witty-crayon-22786
10/15/2015, 7:41 PMregex would probably work. think the trie is good to have though. - h
happy-kitchen-89482
10/15/2015, 7:41 PMI'll keep it for now - h
happy-kitchen-89482
10/15/2015, 7:41 PMIt's simple - w
witty-crayon-22786
10/15/2015, 7:41 PMlots of stuff in the codebase should probably be in path tries - h
happy-kitchen-89482
10/15/2015, 7:41 PMAlthough the regex would make it really easy to capture the language - w
witty-crayon-22786
10/15/2015, 7:42 PMrooted products, etc. - h
happy-kitchen-89482
10/15/2015, 7:42 PMyeah - h
happy-kitchen-89482
10/15/2015, 10:13 PM@witty-crayon-22786: done, PTAL - w
witty-crayon-22786
10/15/2015, 10:13 PMlooking - w
witty-crayon-22786
10/15/2015, 10:14 PM@happy-kitchen-89482: awesome. like what it did to the options. - w
witty-crayon-22786
10/15/2015, 10:15 PMreviewing more deeply. - w
witty-crayon-22786
10/15/2015, 10:24 PM@happy-kitchen-89482: #shipit with comments. @fancy-queen-20734 is out sick today, so should be fine if you don't wait. - h
happy-kitchen-89482
10/15/2015, 10:24 PMthx - c
cuddly-architect-27013
10/15/2015, 10:51 PMis there something one needs to do to be eligible as a reviewer in rbcommons…beyond having the account? i can’t add certain (newer) people as reviewers, and they can’t add me - c
cuddly-architect-27013
10/15/2015, 10:51 PMdidn’t see anything in the contribute guide but i mighta missed it - w
witty-crayon-22786
10/15/2015, 11:08 PMi think it's still the case that we wait for people to become committers before marking them there - c
cuddly-architect-27013
10/15/2015, 11:10 PMoh, ok sounds good - w
witty-crayon-22786
10/15/2015, 11:16 PMcommitters nominated after 10 commits - w
witty-crayon-22786
10/15/2015, 11:17 PMso review early and often! 😉 - w
witty-crayon-22786
10/15/2015, 11:17 PMsmaller is better - b
bored-art-40741
10/15/2015, 11:19 PMThat is how it is, though I don't think that's how it should be. I'd mark this as a quirk of RBC - w
witty-crayon-22786
10/15/2015, 11:19 PMah - b
bored-art-40741
10/15/2015, 11:19 PMIf someone has made an account there's no reason they shouldn't be able to be a reviewer - w
witty-crayon-22786
10/15/2015, 11:20 PMhm. then should we be marking more folks? - b
bored-art-40741
10/15/2015, 11:20 PMI guess it's a question of what it means - b
bored-art-40741
10/15/2015, 11:20 PMimo all reviewers are equal, since an elected committer at the end of the day needs to look at the review before upstreaming and confirm that it was done properly