https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    10/09/2015, 11:59 PM
    patterns make a lazy lookup safe
  • h

    happy-kitchen-89482

    10/09/2015, 11:59 PM
    Right now we eagerly eval all the bootstrap BUILD files, and those contain the source_root decls
  • w

    witty-crayon-22786

    10/10/2015, 12:00 AM
  • h

    happy-kitchen-89482

    10/10/2015, 12:00 AM
    I'm not sure what will break if we stop doing that.
  • h

    happy-kitchen-89482

    10/10/2015, 12:00 AM
    There are other methods on SourceRoot than find()
  • w

    witty-crayon-22786

    10/10/2015, 12:00 AM
    the implementation of SourceRoot.find goes looking
  • h

    happy-kitchen-89482

    10/10/2015, 12:00 AM
    find() isn't the one I'm worried about
  • w

    witty-crayon-22786

    10/10/2015, 12:01 AM
    and nothing really explodes if you define a target outside a source root
  • h

    happy-kitchen-89482

    10/10/2015, 12:01 AM
    we have things like 
    SourceRoot.all_roots()
  • e

    enough-analyst-54434

    10/10/2015, 12:01 AM
    By lazy I mean a utility that is handed a list of paths and returns suffixes
  • e

    enough-analyst-54434

    10/10/2015, 12:01 AM
    Purely based on patterns
  • e

    enough-analyst-54434

    10/10/2015, 12:01 AM
    Publish would use the utility to make source jars
  • e

    enough-analyst-54434

    10/10/2015, 12:02 AM
    My guess is others do something more like that
  • w

    witty-crayon-22786

    10/10/2015, 12:02 AM
    @happy-kitchen-89482: all_roots is only used from 
    src/python/pants/backend/core/tasks/roots.py
    ... arguably should be a special case.
  • w

    witty-crayon-22786

    10/10/2015, 12:03 AM
    should/could
  • w

    witty-crayon-22786

    10/10/2015, 12:03 AM
    @enough-analyst-54434: re "handed a list of paths", that's SourceRoot.find i think
  • e

    enough-analyst-54434

    10/10/2015, 12:03 AM
    Iiuc no mainline dev productivity impacting task needs source roots
  • w

    witty-crayon-22786

    10/10/2015, 12:04 AM
    @enough-analyst-54434: resources
  • e

    enough-analyst-54434

    10/10/2015, 12:04 AM
    There you go
  • w

    witty-crayon-22786

    10/10/2015, 12:04 AM
    and thrift
  • e

    enough-analyst-54434

    10/10/2015, 12:04 AM
    At any rate why not just a dang list!
  • w

    witty-crayon-22786

    10/10/2015, 12:04 AM
    because lots of projects =(
  • e

    enough-analyst-54434

    10/10/2015, 12:04 AM
    We can smooth repo setup
  • e

    enough-analyst-54434

    10/10/2015, 12:05 AM
    I think the Twitter case should not steer this - you need to know to type trait to start a trait
  • w

    witty-crayon-22786

    10/10/2015, 12:05 AM
    @enough-analyst-54434: and the square case
  • e

    enough-analyst-54434

    10/10/2015, 12:05 AM
    So you can be bothered to add a line to a file
  • w

    witty-crayon-22786

    10/10/2015, 12:05 AM
    and anyone else that comes from maven/gradle
  • e

    enough-analyst-54434

    10/10/2015, 12:05 AM
    Squares is autogen
  • w

    witty-crayon-22786

    10/10/2015, 12:06 AM
    ...with maven_layout. so, currently broken
  • e

    enough-analyst-54434

    10/10/2015, 12:06 AM
    Ok -said I'd step away and I will, totally disagree on this
1...539540541...2420Latest