pantsbuild #general

Channels

welcome

github-notifications

announce

full-kilobyte-93429

10/09/2015, 10:57 PM

this test will fail tests/python/pants_test/backend/jvm/tasks:scala_repl_integration

witty-crayon-22786

10/09/2015, 11:10 PM

@full-kilobyte-93429: and checkstyle as well.

witty-crayon-22786

10/09/2015, 11:13 PM

look at the release, then will look at that as well.

full-kilobyte-93429

10/09/2015, 11:16 PM

thanks! @witty-crayon-22786

witty-crayon-22786

10/09/2015, 11:33 PM

https://rbcommons.com/s/twitter/r/2958/

witty-crayon-22786

10/09/2015, 11:34 PM

...i expect the CI to fail because of https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/targets/jar_dependency.py#L71 though.

witty-crayon-22786

10/09/2015, 11:35 PM

@ancient-stone-50795: ^ are we ready to kill that?

witty-crayon-22786

10/09/2015, 11:35 PM

(oof, that one is going to be a lot of fun.)

witty-crayon-22786

10/09/2015, 11:37 PM

oh, shoot. https://rbcommons.com/s/twitter/r/2953/ hasn't shipped.

witty-crayon-22786

10/09/2015, 11:37 PM

will include it here.

witty-crayon-22786

10/09/2015, 11:39 PM

@happy-kitchen-89482: would you mind if i canceled your CI in order to fasttrack this release a bit?

witty-crayon-22786

10/09/2015, 11:40 PM

aha, thank you

witty-crayon-22786

10/09/2015, 11:40 PM

Screen Shot 2015-10-09 at 4.40.24 PM.png

happy-kitchen-89482

10/09/2015, 11:41 PM

I'll wait

witty-crayon-22786

10/09/2015, 11:41 PM

thank you sir.

happy-kitchen-89482

10/09/2015, 11:46 PM

Your job still isn't running

enough-analyst-54434

10/09/2015, 11:47 PM

Mine is blocking: https://travis-ci.org/pantsbuild/pants/builds/84603900

enough-analyst-54434

10/09/2015, 11:47 PM

Killed mine

enough-analyst-54434

10/09/2015, 11:48 PM

It was a .travis.yml tweak that greened on the branch, so not worried about the master run that was that job

happy-kitchen-89482

10/09/2015, 11:51 PM

Re source roots:

witty-crayon-22786

10/09/2015, 11:51 PM

thanks

happy-kitchen-89482

10/09/2015, 11:52 PM

Not sure I want to scan the filesystem on every pants startup, and match a bunch of patterns, just to determine source roots.

happy-kitchen-89482

10/09/2015, 11:53 PM

That seems like a lot of work to detect state that almost never changes.

enough-analyst-54434

10/09/2015, 11:55 PM

My guess is others lazily infer in the tasks that need it

enough-analyst-54434

10/09/2015, 11:56 PM

I'd say static list, tool to generate the list for existing customers

enough-analyst-54434

10/09/2015, 11:56 PM

And maybe patterns go in setup.sh to auto generate that list for starting repos

enough-analyst-54434

10/09/2015, 11:57 PM

Seems like a simple performant 1st step

witty-crayon-22786

10/09/2015, 11:58 PM

@happy-kitchen-89482: source roots are already lazy? not sure why you'd need to scan

witty-crayon-22786

10/09/2015, 11:58 PM

** they are already both lazy and eager

witty-crayon-22786

10/09/2015, 11:58 PM

if one hasn't been registered, we lazily look up whether one is supposed to exist.