https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    10/09/2015, 10:13 PM
    (waiting on a green build for https://rbcommons.com/s/twitter/r/2955/ , then will merge and start the release)
  • w

    witty-crayon-22786

    10/09/2015, 10:13 PM
    sorry for the long lead time
  • e

    enough-analyst-54434

    10/09/2015, 10:19 PM
    We may not be global, but we're continental, so you'll always be releasing late or early for someone!
  • e

    enough-analyst-54434

    10/09/2015, 10:19 PM
    Oh - well
  • e

    enough-analyst-54434

    10/09/2015, 10:20 PM
    England folks and maybe the Wix Isreal folks
  • e

    enough-analyst-54434

    10/09/2015, 10:20 PM
    SO maybe half a globe
  • h

    happy-kitchen-89482

    10/09/2015, 10:25 PM
    Wix are in Israel? I should go visit them next time I'm there.
  • e

    enough-analyst-54434

    10/09/2015, 10:31 PM
    I think so
  • e

    enough-analyst-54434

    10/09/2015, 10:31 PM
    They have ads on Hulu now!
  • e

    enough-analyst-54434

    10/09/2015, 10:32 PM
    Israel seems to be a global powerhouse in things code that goes un-labelled as such, and then per-capita I'm sure its moreso
  • f

    full-kilobyte-93429

    10/09/2015, 10:38 PM
    @enough-analyst-54434: would it be ok to get rid of Executor.Error? it doesn't seem to add too much value
  • f

    full-kilobyte-93429

    10/09/2015, 10:38 PM
    my context is the synthetic jar logic expects an OSError
  • f

    full-kilobyte-93429

    10/09/2015, 10:38 PM
    but executor sees is first and turn oserror into Executor.Error
  • e

    enough-analyst-54434

    10/09/2015, 10:39 PM
    Feel free to subclass Error
  • w

    witty-crayon-22786

    10/09/2015, 10:39 PM
    @full-kilobyte-93429: this is why i say: just do it by default.
  • w

    witty-crayon-22786

    10/09/2015, 10:39 PM
    this conditional thing, especially on exceptions, is awkward
  • f

    full-kilobyte-93429

    10/09/2015, 10:39 PM
    @witty-crayon-22786: that has issues
  • f

    full-kilobyte-93429

    10/09/2015, 10:39 PM
    repl doesn't like it
  • f

    full-kilobyte-93429

    10/09/2015, 10:39 PM
    i haven't tracked down to the root cause yet
  • e

    enough-analyst-54434

    10/09/2015, 10:39 PM
    Yeah - saw that github comment - I was worried about global applicability of this
  • f

    full-kilobyte-93429

    10/09/2015, 10:39 PM
    i suspect it's to do with it's own classLoader
  • w

    witty-crayon-22786

    10/09/2015, 10:39 PM
    so make it configurable on a task-by-task basis
  • e

    enough-analyst-54434

    10/09/2015, 10:40 PM
    Classloaders are not constrained by tasks
  • e

    enough-analyst-54434

    10/09/2015, 10:40 PM
    code can do anything here
  • w

    witty-crayon-22786

    10/09/2015, 10:40 PM
    @enough-analyst-54434: they are in the sense that we know what classloader is running in the 
    repl
    task
  • w

    witty-crayon-22786

    10/09/2015, 10:40 PM
    and in the 
    junit
    task
  • e

    enough-analyst-54434

    10/09/2015, 10:40 PM
    you don't
  • e

    enough-analyst-54434

    10/09/2015, 10:40 PM
    because a junit test can use its own classloader underneth junit, etc
  • w

    witty-crayon-22786

    10/09/2015, 10:40 PM
    the system classloader, surely?
  • e

    enough-analyst-54434

    10/09/2015, 10:41 PM
    no - not at all
1...536537538...2420Latest