https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    10/09/2015, 8:25 PM
    patterns would make more sense for us.
  • h

    happy-kitchen-89482

    10/09/2015, 8:25 PM
    So 1600 BUILD file lines
  • e

    enough-analyst-54434

    10/09/2015, 8:25 PM
    I think starting with no inference and instead a big list seems like the right way to go no?
  • h

    happy-kitchen-89482

    10/09/2015, 8:26 PM
    but not in a single BUILD file...
  • w

    witty-crayon-22786

    10/09/2015, 8:26 PM
    oh. yea, sorry.
  • w

    witty-crayon-22786

    10/09/2015, 8:26 PM
    @enough-analyst-54434: the trouble is that no one knows they need a source root.
  • w

    witty-crayon-22786

    10/09/2015, 8:27 PM
    they think the structure is sufficient
  • e

    enough-analyst-54434

    10/09/2015, 8:27 PM
    But how often do they make one!
  • h

    happy-kitchen-89482

    10/09/2015, 8:27 PM
    Also, and I know I'll get shouted down for this, but do we really care about enforcing the target type restrictions? Why does this matter? And even if it does, why do we need to check it on every invocation of Pants?
  • w

    witty-crayon-22786

    10/09/2015, 8:27 PM
    very often
  • e

    enough-analyst-54434

    10/09/2015, 8:27 PM
    Jesus
  • w

    witty-crayon-22786

    10/09/2015, 8:27 PM
    new projects get created all the time
  • e

    enough-analyst-54434

    10/09/2015, 8:27 PM
    I'll step away and let you guys go on this one
  • w

    witty-crayon-22786

    10/09/2015, 8:27 PM
    and this is boilerplate involved with that. we'd like to move toward The One True layout, but.
  • e

    enough-analyst-54434

    10/09/2015, 8:27 PM
    Thats a mindset/mode I cannot meld with
  • w

    witty-crayon-22786

    10/09/2015, 8:27 PM
    regardless, it's boilerplate.
  • b

    billowy-alarm-80641

    10/09/2015, 8:28 PM
    I think 
    maven_layout()
    is confusing to boot -- I think there are a bunch that have been dropped in by users
  • b

    billowy-alarm-80641

    10/09/2015, 8:28 PM
    that aren't in the right spot, and hence don't actually do anything
  • b

    billowy-alarm-80641

    10/09/2015, 8:28 PM
    but agree with stu -- boilerplate + blind copy/pasta
  • w

    witty-crayon-22786

    10/09/2015, 8:28 PM
    @enough-analyst-54434: in the interest of easier bootstrapping, not having this in either BUILD files or a magic SOURCE_ROOT file would be nice, no?
  • h

    happy-kitchen-89482

    10/09/2015, 8:28 PM
    I'm with John on the insanity of creating new source roots, but I agree that we need to support it more nicely, if only for migration-to-pants purposes.
  • w

    witty-crayon-22786

    10/09/2015, 8:28 PM
    right
  • e

    enough-analyst-54434

    10/09/2015, 8:29 PM
    I think the onboarding right way is plugin can have a default soure roots set
  • w

    witty-crayon-22786

    10/09/2015, 8:29 PM
    even for brand new projects, it's a roadblock
  • h

    happy-kitchen-89482

    10/09/2015, 8:29 PM
    However, anyone want to argue in favor of the importance of enforcing target type restrictions? I'm against them.
  • b

    billowy-alarm-80641

    10/09/2015, 8:29 PM
    Yeah, I've never seen the value of that
  • h

    happy-kitchen-89482

    10/09/2015, 8:29 PM
    And with patterns those get hairier to do
  • e

    enough-analyst-54434

    10/09/2015, 8:29 PM
    Then only if your layout - for say python - is different tha community
  • e

    enough-analyst-54434

    10/09/2015, 8:29 PM
    do you need to source root
  • w

    witty-crayon-22786

    10/09/2015, 8:30 PM
    it's easy enough to enforce the type restrictions later.
1...532533534...2420Latest