https://pantsbuild.org/ logo
Powered by
#general
  • a

    ancient-stone-50795

    07/15/2015, 6:54 PM
    Ok. Our pants script doesn’t use it, but we download a pex file, so that should stay.
  • m

    many-table-69772

    07/15/2015, 6:59 PM
    and so junit in 
    BUILD.tools
    can turn into:
    Copy code
    jar_library(name = 'junit',
            dependencies = [
              '3rdparty:junit'
            ],
            jars = [
              jar(org = 'org.pantsbuild', name = 'junit-runner', rev = '0.0.8'),
            ])
    ?
  • m

    many-table-69772

    07/15/2015, 6:59 PM
    seems to be working
  • a

    ancient-stone-50795

    07/15/2015, 7:00 PM
    I think that will work. The question is which pattern do we want to set forth as an example.
  • s

    silly-article-89931

    07/15/2015, 8:47 PM
    I have a thrift gen question. In my task, I have this:
    Copy code
    @classmethod
  def prepare(cls, options, round_manager):
    super(Vex, cls).prepare(options, round_manager)
    round_manager.require_data('python’)
    That’s supposed to help make sure that any PythonThriftLibrary targets in the graph are codegenned into PythonLibraries before my task executes right? But when I drop a trace and examine my graph (using a PythonBinary input that depends on a PythonThriftLibrary), all I see are the Binary and the ThriftLibrary. Is there something else I’m missing to say “I want Thrift Gen to run before my task executes”?
  • w

    witty-crayon-22786

    07/15/2015, 10:39 PM
    @ancient-stone-50795: sounds like we just encountered an issue where JDK8's rt.jar isn't backwards compatible with JDK7's
  • w

    witty-crayon-22786

    07/15/2015, 10:39 PM
    ie, compile on JDK8 with source=7 target=7 and deploy to JDK7 fails with a runtime error due to a class change
  • a

    ancient-stone-50795

    07/15/2015, 10:39 PM
    You mean not source code compatible?
  • w

    witty-crayon-22786

    07/15/2015, 10:40 PM
    no: library
  • w

    witty-crayon-22786

    07/15/2015, 10:40 PM
    to properly set source/target, need the boot classpath to use the rt.jar for that version i guess?
  • a

    ancient-stone-50795

    07/15/2015, 10:40 PM
    Are you setting -XX:bootstrapclasspath appropriately for jdk7?
  • a

    ancient-stone-50795

    07/15/2015, 10:41 PM
    I owe YOU a coke.
  • w

    witty-crayon-22786

    07/15/2015, 10:41 PM
    things seem to mostly work, except for a change in ConcurrentHashMap
  • b

    bored-art-40741

    07/15/2015, 10:42 PM
    Yup
  • b

    bored-art-40741

    07/15/2015, 10:42 PM
    There are a couple of little things like that
  • b

    bored-art-40741

    07/15/2015, 10:42 PM
    We really should have bootstrap classpath jdk version as a constraint
  • w

    witty-crayon-22786

    07/15/2015, 10:42 PM
    time to code in a real JvmPlatform ?
  • a

    ancient-stone-50795

    07/15/2015, 10:42 PM
    I guess it is actually 
    -Xbootclasspath
  • a

    ancient-stone-50795

    07/15/2015, 10:43 PM
    @jolly-chef-92794: is working on mixed java target versions.
  • a

    ancient-stone-50795

    07/15/2015, 10:43 PM
    We were going to just have a parameter on JvmTarget to add compiler args to start off with.
  • w

    witty-crayon-22786

    07/15/2015, 10:43 PM
    we're not really in favor of that
  • w

    witty-crayon-22786

    07/15/2015, 10:44 PM
    er... compiler args on JvmTarget?
  • a

    ancient-stone-50795

    07/15/2015, 10:44 PM
    java_library and jvm_binary targets would need it.
  • w

    witty-crayon-22786

    07/15/2015, 10:44 PM
    i think that's the wrong direction to head in
  • b

    bored-art-40741

    07/15/2015, 10:45 PM
    What's the alternative?
  • w

    witty-crayon-22786

    07/15/2015, 10:45 PM
    one jvm version for the repo
  • w

    witty-crayon-22786

    07/15/2015, 10:45 PM
    or one jdk, at least
  • a

    ancient-stone-50795

    07/15/2015, 10:45 PM
    Whatever niceties we have to configure them later would all boil down to that eventually. I took precedent from your direction on how to handle manifest entries.
  • a

    ancient-stone-50795

    07/15/2015, 10:46 PM
    We are planning to use the same jdk for the whole repo, but different targets will require 
    -target 7
    vs. 
    -target 8
  • w

    witty-crayon-22786

    07/15/2015, 10:46 PM
    i think the fact that the python backend supports that is an antipattern
1...525354...2420Latest