https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    10/07/2015, 11:17 PM
    its a cala tuple
  • e

    enough-analyst-54434

    10/07/2015, 11:17 PM
    The planner and executor agree on the type of each slot
  • e

    enough-analyst-54434

    10/07/2015, 11:17 PM
    its a struct
  • w

    witty-crayon-22786

    10/07/2015, 11:17 PM
    perfect
  • e

    enough-analyst-54434

    10/07/2015, 11:17 PM
    so we got hung up on the type semantics of tuple?
  • w

    witty-crayon-22786

    10/07/2015, 11:17 PM
    so then it would make sense if there weren't two ways to declare that something is a file
  • w

    witty-crayon-22786

    10/07/2015, 11:17 PM
    no.
  • e

    enough-analyst-54434

    10/07/2015, 11:17 PM
    File
  • e

    enough-analyst-54434

    10/07/2015, 11:18 PM
    agreed on capital F file
  • e

    enough-analyst-54434

    10/07/2015, 11:18 PM
    We should pass nothing as a string if its not a string
  • e

    enough-analyst-54434

    10/07/2015, 11:18 PM
    just like the Address sneaky problem here
  • w

    witty-crayon-22786

    10/07/2015, 11:18 PM
    src/python/pants/option/custom_types.py
    contains file_option, and 
    src/python/pants/base/payload_field.py
    contains SourcesField
  • w

    witty-crayon-22786

    10/07/2015, 11:18 PM
    they're the same darn thing.
  • e

    enough-analyst-54434

    10/07/2015, 11:18 PM
    yes - file_option bad
  • e

    enough-analyst-54434

    10/07/2015, 11:18 PM
    agreed
  • w

    witty-crayon-22786

    10/07/2015, 11:19 PM
    target_option also bad
  • w

    witty-crayon-22786

    10/07/2015, 11:19 PM
    dict option also bad
  • e

    enough-analyst-54434

    10/07/2015, 11:19 PM
    yes
  • w

    witty-crayon-22786

    10/07/2015, 11:19 PM
    etc
  • e

    enough-analyst-54434

    10/07/2015, 11:19 PM
    dict - less clear, but generally yes
  • w

    witty-crayon-22786

    10/07/2015, 11:19 PM
    i just think they should be unified.
  • e

    enough-analyst-54434

    10/07/2015, 11:19 PM
    enumerate they
  • w

    witty-crayon-22786

    10/07/2015, 11:20 PM
    the types of task+target execution inputs, and the types of options
  • w

    witty-crayon-22786

    10/07/2015, 11:20 PM
    because we're gonna put the options in the inputs.
  • w

    witty-crayon-22786

    10/07/2015, 11:20 PM
    we already do. just sneakily.
  • e

    enough-analyst-54434

    10/07/2015, 11:21 PM
    I have no clue what you mean by unified, I simply think things should have unambiguous types period
  • e

    enough-analyst-54434

    10/07/2015, 11:21 PM
    if 2 or more things use the things, they share a type
  • e

    enough-analyst-54434

    10/07/2015, 11:21 PM
    ie I use a semantic file path, you use a semantic file path - we should both use Path
  • w

    witty-crayon-22786

    10/07/2015, 11:21 PM
    ... except file_option and SourcesField
  • e

    enough-analyst-54434

    10/07/2015, 11:21 PM
    today
1...517518519...2420Latest