#general
- c
cuddly-architect-27013
10/06/2015, 10:55 PMthank you! - w
witty-crayon-22786
10/06/2015, 10:55 PMlong queue at the moment - f
fancy-queen-20734
10/06/2015, 10:56 PMI wonder if it’d be worth it to write our own fileset walk. In some profiles I’ve taken recently, fileset walk’s usage of relpath shows up as ~18% of total time. - r
rough-minister-58256
10/06/2015, 10:57 PMdidn’t Stu implement a faster_relpath? - r
rough-minister-58256
10/06/2015, 10:58 PMmay be worth looking into a C module or ctypes for performance - b
bored-art-40741
10/06/2015, 10:59 PMMonkey patch os.path.relpath to be fast_relpath? - r
rough-minister-58256
10/06/2015, 10:59 PMcringes - b
bored-art-40741
10/06/2015, 10:59 PM(/s) - b
bored-art-40741
10/06/2015, 10:59 PMBut really: https://pypi.python.org/pypi/scandir - r
rough-minister-58256
10/06/2015, 10:59 PMwe actually experimented with this right when it shipped in py3 - r
rough-minister-58256
10/06/2015, 11:00 PMdidn’t see any real speedup from it - w
witty-crayon-22786
10/06/2015, 11:00 PM@fancy-queen-20734: in which walks? - w
witty-crayon-22786
10/06/2015, 11:00 PM(sidenote: one of our big walks is gone) - w
witty-crayon-22786
10/06/2015, 11:00 PM - f
fancy-queen-20734
10/06/2015, 11:00 PMwrapped glob eval from BUILD file declarations I think - w
witty-crayon-22786
10/06/2015, 11:01 PMshould be daemonized soon - m
mammoth-pharmacist-54215
10/06/2015, 11:01 PM@rough-minister-58256: when we shipped in py3? - r
rough-minister-58256
10/06/2015, 11:01 PMwhen https://www.python.org/dev/peps/pep-0471/ (os.scandir/os.walk optimizations) shipped in python 3.5.x - m
mammoth-pharmacist-54215
10/06/2015, 11:02 PMwas aware of that, it sounded like you were talking about a pants python3 release… sorry I misunderstood. - b
bored-art-40741
10/06/2015, 11:02 PMWe theoretically already support py3 - m
mammoth-pharmacist-54215
10/06/2015, 11:03 PM@bored-art-40741: I’m pretty sure we have some code that would break in python 3. - b
bored-art-40741
10/06/2015, 11:03 PMYeah, without CI support we can't truly say we support py3. But we go through pains in CR to make it polyglot, so if there are incompatibilities they are probably minor - r
rough-minister-58256
10/06/2015, 11:04 PMwe need a tox setup like pex has - b
bored-art-40741
10/06/2015, 11:05 PMYeah, I've been dropping the ball on getting us a proper jenkins cluster set up - b
bored-art-40741
10/06/2015, 11:05 PMI'll work on that again this week - r
rough-minister-58256
10/06/2015, 11:06 PM👍 - r
rough-minister-58256
10/06/2015, 11:07 PM - r
rough-minister-58256
10/06/2015, 11:08 PMruns in travis etc - r
rough-minister-58256
10/06/2015, 11:08 PM(if we actually care about python3x support) - b
bored-art-40741
10/06/2015, 11:08 PMWe do