https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    10/02/2015, 12:27 AM
    oh my
  • b

    bored-art-40741

    10/02/2015, 12:28 AM
    Do you have any scalac plugins?
  • w

    witty-crayon-22786

    10/02/2015, 12:28 AM
  • w

    witty-crayon-22786

    10/02/2015, 12:28 AM
    no, no scalac plugins
  • b

    bored-art-40741

    10/02/2015, 12:28 AM
    Ah okay
  • b

    bored-art-40741

    10/02/2015, 12:28 AM
    The plugin docs are pretty lacking, and I'm concerned that some of ours will break in the upgrade
  • w

    witty-crayon-22786

    10/02/2015, 12:29 AM
    @bored-art-40741: not sure if you guys have pulled in https://rbcommons.com/s/twitter/r/2891/ yet, but it helps alot
  • w

    witty-crayon-22786

    10/02/2015, 12:29 AM
    makes maintaining a branch really straightforward.
  • b

    bored-art-40741

    10/02/2015, 12:29 AM
    Very nice
  • b

    bored-art-40741

    10/02/2015, 12:29 AM
    I assume we'll pick it up with tomorrow's release!
  • b

    bored-art-40741

    10/02/2015, 12:30 AM
    We just finished our finagle upgrade, which was our big worry point for 2.11
  • b

    bored-art-40741

    10/02/2015, 12:30 AM
    Since we've historically had issues with upgrading finagle
  • b

    bored-art-40741

    10/02/2015, 12:34 AM
    @witty-crayon-22786: Any pointers on 2.11? Have you noticed better compilation or runtime performance?
  • w

    witty-crayon-22786

    10/02/2015, 12:40 AM
    we have not... i think if at some point we're upgrading before the first final release of a scala version we'll invest more time
  • w

    witty-crayon-22786

    10/02/2015, 12:41 AM
    ...but this was mostly catchup
  • b

    bored-art-40741

    10/02/2015, 12:42 AM
    Is 2.12 actually out?
  • w

    witty-crayon-22786

    10/02/2015, 12:42 AM
    no
  • b

    bored-art-40741

    10/02/2015, 12:42 AM
    Hey, that makes you bleeding edge!
  • w

    witty-crayon-22786

    10/02/2015, 12:42 AM
    heh.
  • f

    freezing-motorcycle-14222

    10/02/2015, 1:37 AM
    I think we need integration tests around benchmarking. I was trying to do a smoke test for narrowing the scope of the 
    bench
    task and discovered that the 
    bench
    goal no longer works because of this review board: https://rbcommons.com/s/twitter/r/2651/. Now it always fails with:
    Copy code
    Exception message: A valid distribution is required, given: None
  • e

    enough-analyst-54434

    10/02/2015, 1:42 AM
    Crush it
  • e

    enough-analyst-54434

    10/02/2015, 1:43 AM
    But also - a unit test would be just fine
  • e

    enough-analyst-54434

    10/02/2015, 1:44 AM
    If a Task is set up right, a TaskTestBase will just work and wire the needed subsystems
  • e

    enough-analyst-54434

    10/02/2015, 1:44 AM
    if it's not - it'll die
  • b

    bored-art-40741

    10/02/2015, 1:44 AM
    It would also be really handy for our integration tests to make it into coverage
  • e

    enough-analyst-54434

    10/02/2015, 1:44 AM
    Eh
  • e

    enough-analyst-54434

    10/02/2015, 1:44 AM
    For fell-good?
  • e

    enough-analyst-54434

    10/02/2015, 1:44 AM
    feel
  • e

    enough-analyst-54434

    10/02/2015, 1:45 AM
    I want people to stop writing them ish!
  • b

    bored-art-40741

    10/02/2015, 1:45 AM
    Code that's entirely uncovered is dangerous
1...488489490...2420Latest