https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    10/01/2015, 4:48 PM
    that would be a bug then
  • b

    bored-art-40741

    10/01/2015, 4:48 PM
    I disagree
  • w

    witty-crayon-22786

    10/01/2015, 4:48 PM
    classpaths are ordered, period
  • w

    witty-crayon-22786

    10/01/2015, 4:48 PM
    so if the resolver isn't giving them to you in a stable order, that's a bug in the resolver
  • w

    witty-crayon-22786

    10/01/2015, 4:48 PM
    ClasspathProducts preserves the order it gets from ivy
  • w

    witty-crayon-22786

    10/01/2015, 4:48 PM
    because it's meaningful
  • b

    bored-art-40741

    10/01/2015, 4:48 PM
    hmmmm
  • w

    witty-crayon-22786

    10/01/2015, 4:49 PM
    even in your fully resolved case, it matters
  • w

    witty-crayon-22786

    10/01/2015, 4:50 PM
    because there are almost certainly a few duped classes in there
  • b

    bored-art-40741

    10/01/2015, 4:50 PM
    yeah
  • b

    bored-art-40741

    10/01/2015, 4:50 PM
    Kind of a pain, but I guess I can just order lexicographically
  • w

    witty-crayon-22786

    10/01/2015, 4:50 PM
    or preserve the ordering in your file
  • w

    witty-crayon-22786

    10/01/2015, 4:50 PM
    to allow for tunability if you do want to prioritize things?
  • b

    bored-art-40741

    10/01/2015, 4:51 PM
    "file"?
  • w

    witty-crayon-22786

    10/01/2015, 4:51 PM
    you're reading the full list of resolved artifacts from somewhere i think?
  • b

    bored-art-40741

    10/01/2015, 4:51 PM
    No
  • w

    witty-crayon-22786

    10/01/2015, 4:51 PM
    "the pinned file"
  • b

    bored-art-40741

    10/01/2015, 4:51 PM
    That only pins things that need to be pinned
  • w

    witty-crayon-22786

    10/01/2015, 4:52 PM
    ah
  • b

    bored-art-40741

    10/01/2015, 4:52 PM
    Many things are unambiguous and therefore don't need to be
  • b

    bored-art-40741

    10/01/2015, 4:53 PM
    Easy enough to sort arbitrarily at the end
  • w

    witty-crayon-22786

    10/01/2015, 4:53 PM
    yea
  • w

    witty-crayon-22786

    10/01/2015, 4:53 PM
    well... or apply your overrides deterministically?
  • b

    bored-art-40741

    10/01/2015, 4:53 PM
    One of those scary bugs to hit though--this doesn't actually break anything, just quietly slows down everyone's productivity
  • w

    witty-crayon-22786

    10/01/2015, 4:54 PM
    if you are still using ivy for the rest of it, would be good to preserve that
  • b

    bored-art-40741

    10/01/2015, 4:54 PM
    We only use ivy for tool classpaths
  • b

    bored-art-40741

    10/01/2015, 4:54 PM
    We straight up unregister 
    resolve.ivy
  • w

    witty-crayon-22786

    10/01/2015, 4:54 PM
    er... i thought you said you only have some things pinned...?
  • w

    witty-crayon-22786

    10/01/2015, 4:54 PM
    oh... the rest is based on your own resolution code.
  • b

    bored-art-40741

    10/01/2015, 4:54 PM
    Correct, what we have is a fully blown resolver
1...485486487...2420Latest