https://pantsbuild.org/ logo
Powered by
#general
  • l

    limited-terabyte-34878

    09/28/2015, 10:18 PM
    yeah i see
  • s

    stocky-salesmen-83101

    09/28/2015, 10:23 PM
    i guess they’re both offline @witty-crayon-22786 ?
  • w

    witty-crayon-22786

    09/28/2015, 10:23 PM
    they'll be back
  • s

    stocky-salesmen-83101

    09/28/2015, 10:24 PM
    maybe @enough-analyst-54434 is climbing a mountain now.
  • w

    witty-crayon-22786

    09/28/2015, 10:24 PM
    😃
  • h

    happy-kitchen-89482

    09/28/2015, 10:52 PM
    I'm online
  • h

    happy-kitchen-89482

    09/28/2015, 10:53 PM
    Um, I'm still a bit opposed to adding yet more complication in BUILD files and in test running tasks.
  • h

    happy-kitchen-89482

    09/28/2015, 10:53 PM
    I'd be more open to it if I saw how much common code it was possible to extract.
  • h

    happy-kitchen-89482

    09/28/2015, 10:53 PM
    Can you explain again why the existing functionality isn't sufficient?
  • w

    witty-crayon-22786

    09/28/2015, 10:57 PM
    @happy-kitchen-89482: there would not be any shared code between languages; this might be an opportunity to add shared abort functionality, and set us up for more features like that in the future cc @limited-terabyte-34878 , @stocky-salesmen-83101
  • w

    witty-crayon-22786

    09/28/2015, 10:57 PM
    and then when we need test timeout support in go, we don't have to wait for the language to add it
  • b

    bright-dinner-81701

    09/28/2015, 10:58 PM
    @witty-crayon-22786: @enough-analyst-54434 this works now that the other PR is in master https://rbcommons.com/s/twitter/r/2900/
  • w

    witty-crayon-22786

    09/28/2015, 10:59 PM
    nice
  • w

    witty-crayon-22786

    09/28/2015, 10:59 PM
    @bright-dinner-81701: can you add a README that explains a few of the supported workflows?
  • h

    happy-kitchen-89482

    09/28/2015, 11:00 PM
    You said above, " if we were able to extract a common test base class for the pytest and junit runners"
  • h

    happy-kitchen-89482

    09/28/2015, 11:01 PM
    What would that common test class do, that is shared between languages?
  • w

    witty-crayon-22786

    09/28/2015, 11:01 PM
    support aborting the runner after a timeout
  • w

    witty-crayon-22786

    09/28/2015, 11:01 PM
    either because the runner doesn't support it, or because the runner is deadlocked for some reason or another
  • h

    happy-kitchen-89482

    09/28/2015, 11:04 PM
    Any other useful things we can abstract out? Test discovery?
  • w

    witty-crayon-22786

    09/28/2015, 11:10 PM
    possibly, yea. although i think that requires more support code to "identify" files/classes generically across languages
  • w

    witty-crayon-22786

    09/28/2015, 11:13 PM
    @happy-kitchen-89482: also (and although its existence is awkward already) something like 
    src/python/pants/backend/core/tasks/run_prep_command.py
    would be better implemented in the test runner
  • w

    witty-crayon-22786

    09/28/2015, 11:14 PM
    also, both support writing xml... likely there is stuff that could be unified there
  • w

    witty-crayon-22786

    09/28/2015, 11:14 PM
    ...and sharding
  • w

    witty-crayon-22786

    09/28/2015, 11:14 PM
    ...actually, this seems really obvious the more i walk through 
    ./pants help test
  • h

    happy-kitchen-89482

    09/28/2015, 11:28 PM
    Yeah, sharding, in particular
  • h

    happy-kitchen-89482

    09/28/2015, 11:29 PM
    I'm open to this if there need is true. I just haven't yet heard a convincing reason why the existing functionality isn't enough.
  • w

    witty-crayon-22786

    09/28/2015, 11:31 PM
    @happy-kitchen-89482: i think the generic support speaks for itself. but i think @stocky-salesmen-83101 's original reasoning was more to do with not really knowing how to ratchet test timeout definitions when they're defined in code rather than config. cc @limited-terabyte-34878
  • a

    ancient-stone-50795

    09/28/2015, 11:43 PM
    I could certainly benefit from a high level timeout in pants for testing. I have a regression test that invokes ./pants test <target> in a loop. Occasionally tests get stuck and the entire job times out. If I could just set a 30 minute timeout on the entire ./pants run it would be a huge help.
  • a

    ancient-stone-50795

    09/28/2015, 11:44 PM
    But that doesn’t even have to be a test specific feature. It could be very general. I have a pants wrapper script and have considered implementing it there.
  • w

    witty-crayon-22786

    09/28/2015, 11:45 PM
    yea... we have the "above pants" solution implemented already, but it comes with a lot of not knowing what timed out
1...475476477...2420Latest