https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    09/24/2015, 11:38 PM
    Copy code
    spec_excludes: ['.git', 'dist','.idea','.pants.d']
  • b

    bored-art-40741

    09/24/2015, 11:38 PM
    Yeah, but there's always one you forget
  • h

    happy-kitchen-89482

    09/24/2015, 11:39 PM
    And how is that whitelist different from source_roots?
  • w

    witty-crayon-22786

    09/24/2015, 11:39 PM
    (ours)
  • h

    happy-kitchen-89482

    09/24/2015, 11:39 PM
    I don't think we should have to enumerate `.dir`s
  • h

    happy-kitchen-89482

    09/24/2015, 11:39 PM
    or dist
  • h

    happy-kitchen-89482

    09/24/2015, 11:39 PM
    pants knows about that one
  • b

    bored-art-40741

    09/24/2015, 11:39 PM
    Just saying, I can count the four directories that we actually want to descend into on one hand
  • b

    bored-art-40741

    09/24/2015, 11:39 PM
    It's fast and easy
  • b

    bored-art-40741

    09/24/2015, 11:39 PM
    Done
  • w

    witty-crayon-22786

    09/24/2015, 11:39 PM
    we can't, unfortunately.
  • b

    bored-art-40741

    09/24/2015, 11:39 PM
    src, test, verification, 3rdparty
  • w

    witty-crayon-22786

    09/24/2015, 11:39 PM
    because maven_layout
  • h

    happy-kitchen-89482

    09/24/2015, 11:40 PM
    Yes, and those are exactly our source roots...
  • b

    bored-art-40741

    09/24/2015, 11:40 PM
    They aren't source roots
  • b

    bored-art-40741

    09/24/2015, 11:40 PM
    Subdirs of them are
  • h

    happy-kitchen-89482

    09/24/2015, 11:40 PM
    same difference
  • h

    happy-kitchen-89482

    09/24/2015, 11:40 PM
    and 3rdparty I guess
  • b

    bored-art-40741

    09/24/2015, 11:40 PM
    Then again, just adding a couple more excludes we know about scratches this itch for now
  • h

    happy-kitchen-89482

    09/24/2015, 11:40 PM
    I don't want to have to maintain 2 95%-overlapping whitelists.
  • b

    bored-art-40741

    09/24/2015, 11:40 PM
    Until we really lock down our notion of source roots
  • w

    witty-crayon-22786

    09/24/2015, 11:40 PM
    if as part of a cleanup of source roots you define where it is legal to define source roots (whoa, meta), then we'd be happy.
  • h

    happy-kitchen-89482

    09/24/2015, 11:40 PM
    yes, agreed
  • h

    happy-kitchen-89482

    09/24/2015, 11:41 PM
    Anyway, with that out of the way, I can re-focus on how friggin expensive BUILD file parsing is...
  • w

    witty-crayon-22786

    09/24/2015, 11:41 PM
    obviously in that case source_roots should not live in BUILD files
  • h

    happy-kitchen-89482

    09/24/2015, 11:41 PM
    It now takes 25 seconds (down from 50) to run ./pants list in our repo.
  • w

    witty-crayon-22786

    09/24/2015, 11:41 PM
    nice 😃
  • h

    happy-kitchen-89482

    09/24/2015, 11:42 PM
    Of that 25 seconds, 70% is in BuildFileAddressMapper.scan_addresses
  • h

    happy-kitchen-89482

    09/24/2015, 11:42 PM
    56% is in parse_build_file()
  • h

    happy-kitchen-89482

    09/24/2015, 11:42 PM
    of that, 20% is in exec_, 35% is in initialize_parse_state
1...460461462...2420Latest