https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    09/24/2015, 10:43 PM
    Thats the code paste thing
  • f

    freezing-motorcycle-14222

    09/24/2015, 10:43 PM
    Ah, thanks!
  • h

    happy-kitchen-89482

    09/24/2015, 11:32 PM
    Yep, the underlying os.walk was walking into .git, .pants.d, .local_artifact_cache...
  • h

    happy-kitchen-89482

    09/24/2015, 11:32 PM
    a quick fix makes that bit much faster (this is when operating on, say, 
    ::
    )
  • b

    bored-art-40741

    09/24/2015, 11:34 PM
    Copy code
    spec_excludes: [
    '%(pants_workdir)s',
    '%(buildroot)s/dist',
    '%(buildroot)s/out',
  ]
  • b

    bored-art-40741

    09/24/2015, 11:34 PM
    Those are supposed to be excluded
  • b

    bored-art-40741

    09/24/2015, 11:34 PM
    Did that regress?
  • h

    happy-kitchen-89482

    09/24/2015, 11:34 PM
    they don't include e.g., .local_artifact_cache
  • h

    happy-kitchen-89482

    09/24/2015, 11:35 PM
    or .git
  • b

    bored-art-40741

    09/24/2015, 11:35 PM
    Good point
  • h

    happy-kitchen-89482

    09/24/2015, 11:35 PM
    but really we should programmatically ignore any hidden files
  • b

    bored-art-40741

    09/24/2015, 11:35 PM
    In our repo we really want a whitelist
  • h

    happy-kitchen-89482

    09/24/2015, 11:35 PM
    anything that starts with a dot
  • h

    happy-kitchen-89482

    09/24/2015, 11:35 PM
    Actually we should only scan source_roots
  • b

    bored-art-40741

    09/24/2015, 11:35 PM
    Could also just respect .gitignore
  • b

    bored-art-40741

    09/24/2015, 11:35 PM
    Limiting to source roots makes sense
  • b

    bored-art-40741

    09/24/2015, 11:36 PM
    Of course, right now we register source roots by parsing BUILD files...
  • h

    happy-kitchen-89482

    09/24/2015, 11:36 PM
    yes, that'll have to be a TODO
  • b

    bored-art-40741

    09/24/2015, 11:36 PM
    oh and
  • b

    bored-art-40741

    09/24/2015, 11:36 PM
    We synthesize source roots within .pants.d
  • b

    bored-art-40741

    09/24/2015, 11:36 PM
    For codegen
  • h

    happy-kitchen-89482

    09/24/2015, 11:37 PM
    Ugh, yes, so we do.
  • h

    happy-kitchen-89482

    09/24/2015, 11:38 PM
    But do you think :: should operate on those?
  • h

    happy-kitchen-89482

    09/24/2015, 11:38 PM
    Those are an implementation detail
  • b

    bored-art-40741

    09/24/2015, 11:38 PM
    Agreed
  • h

    happy-kitchen-89482

    09/24/2015, 11:38 PM
    For example they may or may not exist
  • h

    happy-kitchen-89482

    09/24/2015, 11:38 PM
    depending on whether you built first or not
  • b

    bored-art-40741

    09/24/2015, 11:38 PM
    I'm just saying, while using source roots seems like a good long term design goal, I think it'll get hairy fast right now
  • h

    happy-kitchen-89482

    09/24/2015, 11:38 PM
    I don't think the output of ./pants list should depend on any prior operations.
  • b

    bored-art-40741

    09/24/2015, 11:38 PM
    All I want in life is a whitelist for this
1...459460461...2420Latest