https://pantsbuild.org/ logo
Powered by
#general
  • e

    enough-analyst-54434

    09/24/2015, 8:18 PM
    @fancy-queen-20734: sgtm - that's pretty old and IIRC by a no-longer-4sq fellow
  • f

    fancy-queen-20734

    09/24/2015, 8:18 PM
    ok
  • w

    witty-crayon-22786

    09/24/2015, 8:23 PM
    Copy code
    * @author John Sirois
  • w

    witty-crayon-22786

    09/24/2015, 8:23 PM
    guava 19, destroyer of deprecated apis approacheth
  • b

    bored-art-40741

    09/24/2015, 8:24 PM
    think I figured it out
  • b

    bored-art-40741

    09/24/2015, 8:24 PM
    I believe it's 
    global.CompilationUnit.outdir
  • w

    witty-crayon-22786

    09/24/2015, 8:25 PM
    sounds reasonable, yea.
  • w

    witty-crayon-22786

    09/24/2015, 8:25 PM
    @bored-art-40741: please make sure you use their abstract file writing APIs
  • w

    witty-crayon-22786

    09/24/2015, 8:25 PM
    otherwise you will likely be left behind by the jar patch
  • b

    bored-art-40741

    09/24/2015, 8:26 PM
    We're in the process of eliminating this plugin as it is
  • b

    bored-art-40741

    09/24/2015, 8:26 PM
    We just want to unblock for now
  • b

    bored-art-40741

    09/24/2015, 8:26 PM
    If we haven't eliminated it by the time we upgrade to write-to-jar, I'll go back and refine it
  • b

    bored-art-40741

    09/24/2015, 8:26 PM
    Although while I have you: where are the docs on that API?
    😂 1
  • w

    witty-crayon-22786

    09/24/2015, 8:27 PM
    oh, you weren't joking?
  • e

    enough-analyst-54434

    09/24/2015, 8:27 PM
    I read alot of source at the time
  • w

    witty-crayon-22786

    09/24/2015, 8:27 PM
    hm
  • w

    witty-crayon-22786

    09/24/2015, 8:28 PM
    @enough-analyst-54434: a neat sideeffect of @fancy-queen-20734 's classpath hashing patch is that sources are required to cross compile with their dependees
  • w

    witty-crayon-22786

    09/24/2015, 8:28 PM
    kindof awesome actually
  • e

    enough-analyst-54434

    09/24/2015, 8:28 PM
    what is cross compile?
  • w

    witty-crayon-22786

    09/24/2015, 8:28 PM
    so there is one binary that uses guava 19+, and thus src/java/com/twitter/common/args/apt needs to cross compile
  • w

    witty-crayon-22786

    09/24/2015, 8:29 PM
    it needs to be source compatible with both guava 16 and 19
  • w

    witty-crayon-22786

    09/24/2015, 8:29 PM
    not binary compatible
  • w

    witty-crayon-22786

    09/24/2015, 8:29 PM
    because we catch the inconsistency at compile time
  • e

    enough-analyst-54434

    09/24/2015, 8:29 PM
    k - gotcha
  • w

    witty-crayon-22786

    09/24/2015, 8:29 PM
    (which is fine if you have a proper deprecation cycle)
  • w

    witty-crayon-22786

    09/24/2015, 8:30 PM
    i say "cross compile", because that's the term used in scala land to describe being source compatible with both scala N and scala N+1
  • e

    enough-analyst-54434

    09/24/2015, 8:30 PM
    Neat feature - although I'm not happy with a codebase I control needing both!
  • b

    bright-dinner-81701

    09/24/2015, 8:30 PM
    @enough-analyst-54434, @witty-crayon-22786 just opened PR https://github.com/pantsbuild/pants/pull/2267
  • e

    enough-analyst-54434

    09/24/2015, 8:30 PM
    Is this needed?
  • e

    enough-analyst-54434

    09/24/2015, 8:31 PM
    Can we not just be 19 all around?
1...453454455...2420Latest