Ergonomic, hermetic, user-friendly software build system for Python, Go, Java, Kotlin, Protobuf, Scala, Shell. Pants lets you fearlessly scale up your codebase!

Pants

And then we can get a handle on it in `compile_classpath` later?

and track things the analysis doesn't know about as "untracked"

it'll go in either classes_by_target or resources_by_target

(but either way, it'll be on the classpath)

Hello Itay.  Does anyone have any opinions on the proposed change in <https://rbcommons.com/s/twitter/r/2848/>. I advised that we don’t watch to check the filesystem in Target.__init__()

I tend to agree.  I've looked at this issue and tbh I don't think there's a better solution than what we already have

IMO the exception in the issue is perfectly clear

About the best alternative I can come up with is an entirely new lifecycle method on Target, e.g. `Target.validate()` which is called at a well defined time

Putting it in Target.__init__ is too early.  Putting it somewhere in the fingerprint code doesn't give you any more information than the existing exception.  Putting it in Task code doesn't have a strong enough guarantee that some earlier task won't try to fingerprint it first

For reference - the mis-referenced bug in that RB is here: <https://github.com/pantsbuild/pants/issues/2049>

<@U06A03HV1>: We have another type of hang that seems rarer, but there's a live one now

It's not our locking issue, and it's burning 4 cores at 100% nonstop

-.txt

The severity of the hang (doing this for 30+ minutes when we don't have any targets that take over a minute in general) seems to indicate some sort of weird incremental compilation edge case

I'm having him grab another jstack, then kill and attempt to repro

Unless there's something else you'd be interested in seeing before he kills it?

no, that looks like something interesting enough to investigate on its own

If he repros again, I'm going to snag a copy of his .pants.d for reference and then see if a clean fixes it (implicating incremental compilation)

...hm. despite that saying "no deadlocks found", it actually looks exactly like a deadlock, heh