https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    09/23/2015, 9:02 PM
    Or maybe it was really pathological scala
  • e

    enough-analyst-54434

    09/23/2015, 9:04 PM
    We haven't fixed jarjar except for what @jolly-chef-92794 just did in https://github.com/pantsbuild/jarjar/pull/8
  • e

    enough-analyst-54434

    09/23/2015, 9:04 PM
    FAPP jarjar does ~nothing - its all asm
  • a

    ancient-stone-50795

    09/23/2015, 9:05 PM
  • a

    ancient-stone-50795

    09/23/2015, 9:36 PM
    Ok, my proposed fix to jar-tool and newline challenged services files is up at https://rbcommons.com/s/twitter/r/2875/
  • e

    enough-analyst-54434

    09/23/2015, 9:36 PM
    @billowy-alarm-80641: should review too
  • a

    ancient-stone-50795

    09/23/2015, 9:37 PM
    added Andy
  • e

    enough-analyst-54434

    09/23/2015, 9:37 PM
    ty
  • r

    rough-minister-58256

    09/23/2015, 9:37 PM
    so, the string-in-commit (e.g. ‘Fixes #1234’) in an RB comment seems to make github auto-close the PR and even references the commit that closed it.
  • r

    rough-minister-58256

    09/23/2015, 9:37 PM
    seems ideal for PR hygiene
  • e

    enough-analyst-54434

    09/23/2015, 9:38 PM
    The templating for RB Nick pointed out will let us s/Bugs closed:/Fixes #/
  • e

    enough-analyst-54434

    09/23/2015, 9:38 PM
    I'm excited for the templating to ship!
  • r

    rough-minister-58256

    09/23/2015, 9:38 PM
    oh nice
  • e

    enough-analyst-54434

    09/23/2015, 9:38 PM
    Although, that won't work
  • e

    enough-analyst-54434

    09/23/2015, 9:38 PM
    may not fix all bugs referenced
  • e

    enough-analyst-54434

    09/23/2015, 9:39 PM
    Doing this manually good enough - nice trick!
  • b

    billowy-alarm-80641

    09/23/2015, 9:39 PM
    Okay, thanks @ancient-stone-50795, I'll take a look
  • r

    rough-minister-58256

    09/23/2015, 9:45 PM
    apparently to close multiple bugs you have to prefix each bug ID with one of the magic strings (closed is one of them) - so the templating would have to do ‘Closed #1, Closed #2, Closed #3’ to get all 3.
  • r

    rough-minister-58256

    09/23/2015, 9:45 PM
  • j

    jolly-chef-92794

    09/23/2015, 9:54 PM
    Looks like Java8 support works fine just by upgrading asm: https://github.com/pantsbuild/jarjar/pull/11
  • e

    enough-analyst-54434

    09/23/2015, 9:57 PM
    cool
  • e

    enough-analyst-54434

    09/23/2015, 10:03 PM
    Eric's got 'TOOD
  • b

    billowy-alarm-80641

    09/23/2015, 10:04 PM
    I know I'm not going to fuck with him. 😉
  • a

    ancient-stone-50795

    09/23/2015, 10:41 PM
    TOOD(zundel): will release jarjar and jar-tool.
  • e

    enough-analyst-54434

    09/23/2015, 10:42 PM
    That's the 'tude I can appreciate
  • e

    enough-analyst-54434

    09/23/2015, 10:42 PM
    Thank you
  • a

    ancient-stone-50795

    09/23/2015, 10:43 PM
    I am pleasantly surprised that Travis is so fast this afternoon. I have an event to go to tonight, so the release might be later. We’ve got several new services moving over to pants that exposed these two bugs.
  • e

    enough-analyst-54434

    09/23/2015, 10:44 PM
    Travis fast == pants devs lazy
  • a

    ancient-stone-50795

    09/23/2015, 10:44 PM
    It seems that lately Pants has been winning hearts and minds around the SF office. And also I found that our usage tracker was under-counting!
  • f

    fancy-queen-20734

    09/23/2015, 10:44 PM
    Can a tool classpath depend on sources if the tool runs after compile?
1...443444445...2420Latest