https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    09/23/2015, 8:12 PM
    not really... got an "URGENT MEETING" request
  • w

    witty-crayon-22786

    09/23/2015, 8:12 PM
    so on for a few minutes
  • w

    witty-crayon-22786

    09/23/2015, 8:12 PM
    le sigh
  • m

    mammoth-pharmacist-54215

    09/23/2015, 8:12 PM
    okay, I’ll leave you be then, g/l with your move.
  • w

    witty-crayon-22786

    09/23/2015, 8:13 PM
    @mammoth-pharmacist-54215: send that email though. those last 3 failures are not related to the release.
  • m

    mammoth-pharmacist-54215

    09/23/2015, 8:13 PM
    one resolved with re-running, the reason I was pinging you was to ask about the other 2
  • m

    mammoth-pharmacist-54215

    09/23/2015, 8:14 PM
    It sounded like you knew what the fix was.
  • w

    witty-crayon-22786

    09/23/2015, 8:14 PM
    they're broken in master; unrelated to the release
  • w

    witty-crayon-22786

    09/23/2015, 8:14 PM
    all i'll say here
  • m

    mammoth-pharmacist-54215

    09/23/2015, 8:14 PM
    Same target passes for me on master
  • w

    witty-crayon-22786

    09/23/2015, 8:15 PM
    non-deterministic
  • a

    ancient-stone-50795

    09/23/2015, 8:56 PM
    @jolly-chef-92794: I think https://github.com/pantsbuild/jarjar/pull/8 is ready to merge
  • a

    ancient-stone-50795

    09/23/2015, 8:56 PM
    Did you want to try fixing the java8 thing before we publish a new jarjar?
  • j

    jolly-chef-92794

    09/23/2015, 8:56 PM
    yeah I’m working on that in a different branch
  • b

    bored-art-40741

    09/23/2015, 8:57 PM
    Since we have jarjar forked, does anyone know how feasible it would be for it to support scala jars?
  • a

    ancient-stone-50795

    09/23/2015, 8:57 PM
    As easy as your next PR.
  • b

    bored-art-40741

    09/23/2015, 8:57 PM
    heh
  • b

    bored-art-40741

    09/23/2015, 8:57 PM
    I believe it would require inspecting the "opaque" annotation fields and rewriting scala references
  • e

    enough-analyst-54434

    09/23/2015, 8:57 PM
    We need an asm equivalent
  • e

    enough-analyst-54434

    09/23/2015, 8:57 PM
    There was scalasig IIRC?
  • e

    enough-analyst-54434

    09/23/2015, 8:58 PM
    Can't remember where scalasig comes from, but it reads the annotation blobs
  • b

    bored-art-40741

    09/23/2015, 8:58 PM
    I'm sure it's possible, I just don't know too much about the state of the art
  • b

    bored-art-40741

    09/23/2015, 8:58 PM
    And we've definitely wanted it before
  • e

    enough-analyst-54434

    09/23/2015, 8:59 PM
    So ... we shade zinc itself in parts
  • e

    enough-analyst-54434

    09/23/2015, 8:59 PM
    So this works for some scala classfile sets at any rate
  • e

    enough-analyst-54434

    09/23/2015, 9:00 PM
    If the annotation blob only contains extra type paramaterization info, we're good
  • e

    enough-analyst-54434

    09/23/2015, 9:00 PM
    if it points to hidden classes, we might not be
  • e

    enough-analyst-54434

    09/23/2015, 9:00 PM
    But I think it can't and still work with the jvm runtime
  • e

    enough-analyst-54434

    09/23/2015, 9:01 PM
    pretty sure you're covered
  • b

    bored-art-40741

    09/23/2015, 9:02 PM
    Interesting, maybe it was because we were attempting this with non-forked jarjar
1...442443444...2420Latest