pantsbuild #general

Channels

welcome

github-notifications

announce

witty-crayon-22786

09/23/2015, 5:21 AM

@bored-art-40741: we double check the cache now

bored-art-40741

09/23/2015, 5:21 AM

To not do unnecessary writes?

bored-art-40741

09/23/2015, 5:21 AM

Or to not do unnecessary compiles?

witty-crayon-22786

09/23/2015, 5:21 AM

the latter

bored-art-40741

09/23/2015, 5:21 AM

Oh that's fantastic!

witty-crayon-22786

09/23/2015, 5:22 AM

so if something has gone in the cache since the initial check, you can still hit

bored-art-40741

09/23/2015, 5:22 AM

Talk about dark horse feature

witty-crayon-22786

09/23/2015, 5:22 AM

the logging sucks though, as you saw

bored-art-40741

09/23/2015, 5:22 AM

No one will complain about logging with that feature in play

bored-art-40741

09/23/2015, 5:22 AM

We have a lot of work to do on isolated logging, but that's a good problem to have

bored-art-40741

09/23/2015, 5:23 AM

"It's difficult for users to interpret how awesome their tool is being"

witty-crayon-22786

09/23/2015, 5:23 AM

@bored-art-40741: you can turn on

capture_log: True

, and it will record a debug log

witty-crayon-22786

09/23/2015, 5:23 AM

and cache it

bored-art-40741

09/23/2015, 5:23 AM

One thing I want to get locked down is the logging and behavior of nailguns

witty-crayon-22786

09/23/2015, 5:24 AM

in .pants.d/compile/jvm/zinc/isolated-logs

bored-art-40741

09/23/2015, 5:24 AM

When we stampede our CIs we still get timeouts and nailguns dying without reporting back to the server that owns them

witty-crayon-22786

09/23/2015, 5:24 AM

yea.

witty-crayon-22786

09/23/2015, 5:24 AM

ok, to sleep for me...

bored-art-40741

09/23/2015, 5:24 AM

Later!

witty-crayon-22786

09/23/2015, 5:24 AM

enjoy your vacation

bored-art-40741

09/23/2015, 5:56 AM

So!

bored-art-40741

09/23/2015, 5:57 AM

It seems like the contract of

./pants bundle

has changed, or maybe we need to populate the products differently in our custom resolver

bored-art-40741

09/23/2015, 5:58 AM

After an upgrade from 47 to 48, one of our CIs which relies on sifting through the contents of

dist/FOO-bundle/libs

is failing, because the libs directory is empty

ancient-stone-50795

09/23/2015, 2:26 PM

@bored-art-40741: That sounds like the —bundle-deployjars option is turned on. I see that it uses the product

jarmap = self.context.products.get('jars’)

. Maybe it needs to be updated to use compile_classpath.

limited-terabyte-34878

09/23/2015, 3:07 PM

k thanks @enough-analyst-54434

enough-analyst-54434

09/23/2015, 3:52 PM

re: bundles, the output contract has not changed, but the product used to form bundles libs/ dir has - its now 'compile_classpath' - a ClasspathProducts product

enough-analyst-54434

09/23/2015, 3:54 PM

And critically, its collects the external classpath via `get_artifact_classpath_entries_for_targets`: https://github.com/pantsbuild/pants/blob/master/src/python/pants/backend/jvm/tasks/classpath_products.py#L230 which relies on population of external jar classpath entries via

add_jars_for_targets

as opposed to

add_fot_target(s)

enough-analyst-54434

09/23/2015, 3:55 PM

I suspect your resolver does not use

add_jars_for_targets

or elese does not populate a 'compile_classpath' with ClasspathProducts, but some other type

bored-art-40741

09/23/2015, 4:42 PM

Ah, I bet it's the former. Thanks!

enough-analyst-54434

09/23/2015, 4:44 PM

Benjy - you're failing in your role as supreme commander / vacation party host - you need to collect the e-devices at the door so no-one vacations wired-up