pantsbuild #general

Channels

welcome

github-notifications

announce

bored-art-40741

09/22/2015, 3:52 AM

Doesn't create its own directory and fails if it doesn't exist

bored-art-40741

09/22/2015, 3:52 AM

sigh

enough-analyst-54434

09/22/2015, 3:53 AM

I think / was worried a bit about ... forget the db

enough-analyst-54434

09/22/2015, 3:53 AM

I seemed to recall it was a compile option of python

enough-analyst-54434

09/22/2015, 3:53 AM

so some might not have it

bored-art-40741

09/22/2015, 3:53 AM

Note: plugin_jars under

compile.zinc

also needs a wrapper target, but the migration script doesn't warn about it

enough-analyst-54434

09/22/2015, 3:53 AM

false!

bored-art-40741

09/22/2015, 3:54 AM

Copy code

Exception message: JVM tool configuration now expects a single target address, use the
following in pants.ini:

[compile.zinc]
plugin-jars: //tool/classpath:address

bored-art-40741

09/22/2015, 3:54 AM

Copy code

plugin_jars: ['//:scalac-lint-plugin', '//:i18n-plugin']

enough-analyst-54434

09/22/2015, 3:54 AM

https://github.com/pantsbuild/pants/blob/master/migrations/options/src/python/migrate_config.py#L344

enough-analyst-54434

09/22/2015, 3:54 AM

+ https://github.com/pantsbuild/pants/blob/master/migrations/options/src/python/migrate_config.py#L451-L501

bored-art-40741

09/22/2015, 3:54 AM

Yes, I saw all of the other ones

bored-art-40741

09/22/2015, 3:54 AM

Copy code

$ ./dist/migrate_config.pex ../0.foursquare.web/pants.ini
Checking config file at ../0.foursquare.web/pants.ini for unmigrated keys.
  Note for scalac in section [scala-platform]: JVM tool classpath spec overrides have migrated from a list of targetaddresses to a single target address.  To migrate a list of addresses you'll need to create a new aggregator target to hold the list like so: `target(name=<your choice>, dependencies=[<list of addresses>])` and then point to its single address.
  Note for xalan in section [resolve.ivy]: JVM tool classpath spec overrides have migrated from a list of targetaddresses to a single target address.  To migrate a list of addresses you'll need to create a new aggregator target to hold the list like so: `target(name=<your choice>, dependencies=[<list of addresses>])` and then point to its single address.
  Note for emma in section [test.junit]: JVM tool classpath spec overrides have migrated from a list of targetaddresses to a single target address.  To migrate a list of addresses you'll need to create a new aggregator target to hold the list like so: `target(name=<your choice>, dependencies=[<list of addresses>])` and then point to its single address.
  Note for junit in section [test.junit]: JVM tool classpath spec overrides have migrated from a list of targetaddresses to a single target address.  To migrate a list of addresses you'll need to create a new aggregator target to hold the list like so: `target(name=<your choice>, dependencies=[<list of addresses>])` and then point to its single address.
  Note for zinc in section [compile.zinc]: JVM tool classpath spec overrides have migrated from a list of targetaddresses to a single target address.  To migrate a list of addresses you'll need to create a new aggregator target to hold the list like so: `target(name=<your choice>, dependencies=[<list of addresses>])` and then point to its single address.

bored-art-40741

09/22/2015, 3:54 AM

I'm just noting that

plugin-jars

was missed

bored-art-40741

09/22/2015, 3:55 AM

Oh it's in there, huh

bored-art-40741

09/22/2015, 3:55 AM

Maybe added in a later rev or something

enough-analyst-54434

09/22/2015, 3:56 AM

No - it does look like I missed that 1

witty-crayon-22786

09/22/2015, 3:57 AM

anyone know of a reason why positive jvm testproject tests shouldn't just go under

tests/scala/org/pantsbuild

etc? confusing?

bored-art-40741

09/22/2015, 3:57 AM

Copy code

File "/Users/pl/code/0.foursquare.web/.pantsenv/lib/python2.7/site-packages/pants/engine/round_engine.py", line 145, in _visit_goal
    context.build_graph)
  File "/Users/pl/code/0.foursquare.web/.pantsenv/lib/python2.7/site-packages/pants/backend/jvm/tasks/bootstrap_jvm_tools.py", line 111, in _alternate_target_roots
    dep_spec = jvm_tool.dep_spec(options)
  File "/Users/pl/code/0.foursquare.web/.pantsenv/lib/python2.7/site-packages/pants/backend/jvm/subsystems/jvm_tool_mixin.py", line 37, in dep_spec
    if dep_spec.startswith('['):

Exception message: 'list' object has no attribute 'startswith'

bored-art-40741

09/22/2015, 3:58 AM

With no mention of which option or even which goal

bored-art-40741

09/22/2015, 3:58 AM

sigh

enough-analyst-54434

09/22/2015, 3:58 AM

Well if you read that code its bending over backwards to try to be super helpful

enough-analyst-54434

09/22/2015, 3:58 AM

It just happens to have a bug

bored-art-40741

09/22/2015, 4:01 AM

maybe

Copy code

[scala-platform]
runtime: ['3rdparty:scala-library-2.10.4', '3rdparty:i18n-library']

bored-art-40741

09/22/2015, 4:01 AM

Also didn't show up in migration warnings

bored-art-40741

09/22/2015, 4:02 AM

But no, that's a list option

bored-art-40741

09/22/2015, 4:02 AM

enough-analyst-54434

09/22/2015, 4:02 AM

You're the one who lauds editing a venv, just edit /Users/pl/code/0.foursquare.web/.pantsenv/lib/python2.7/site-packages/pants/backend/jvm/subsystems/jvm_tool_mixin.py line 37

bored-art-40741

09/22/2015, 4:02 AM

Maybe this is from a plugin

enough-analyst-54434

09/22/2015, 4:02 AM

to not check string