#general
- b
bored-art-40741
09/22/2015, 3:07 AMOh - b
bored-art-40741
09/22/2015, 3:07 AMLet me try that - b
bored-art-40741
09/22/2015, 3:08 AMNope - b
bored-art-40741
09/22/2015, 3:08 AMBut trailing commas too, probably? - e
enough-analyst-54434
09/22/2015, 3:08 AMmaybe yes - b
bored-art-40741
09/22/2015, 3:08 AMWhat exactly is the nature of this change? - b
bored-art-40741
09/22/2015, 3:08 AMAre we really not evaluating these as before? - b
bored-art-40741
09/22/2015, 3:09 AMThat + trailing commas did not help - b
bored-art-40741
09/22/2015, 3:09 AMWe use interpolation in our pants.ini - e
enough-analyst-54434
09/22/2015, 3:10 AMYeah - quick check of pantsbuild/pants pants.ini says trailing works so its not lists in pants.ini must == json - b
bored-art-40741
09/22/2015, 3:10 AMIt's complaining about values which are not actually options, they're just "variables" we use to interpolate into real options - e
enough-analyst-54434
09/22/2015, 3:10 AMpantsbuild/pants pants.ini also uses interpolation in lists - e
enough-analyst-54434
09/22/2015, 3:11 AMI have not seen this complaint before - you may need to just dig - b
bored-art-40741
09/22/2015, 3:11 AMCopy code$ gg "is not a valid JSON" - b
bored-art-40741
09/22/2015, 3:11 AM😕 - e
enough-analyst-54434
09/22/2015, 3:12 AMIts migrate script script specific - e
enough-analyst-54434
09/22/2015, 3:12 AM - e
enough-analyst-54434
09/22/2015, 3:12 AMso maybe just fix that - b
bored-art-40741
09/22/2015, 3:12 AMOh crazy - b
bored-art-40741
09/22/2015, 3:12 AMIt's complaining about all of these "interpolation" lists defined in DEFAULT, but for every single scope - b
bored-art-40741
09/22/2015, 3:12 AMAha, and it's only complaining about the ones that have nested interpolation - e
enough-analyst-54434
09/22/2015, 3:12 AMAnd git blame is squarely Benjy - e
enough-analyst-54434
09/22/2015, 3:12 AMperhaps he had a rationale - b
bored-art-40741
09/22/2015, 3:13 AMAha, I think I see it - e
enough-analyst-54434
09/22/2015, 3:13 AMIts not clear to me why those checks even exist - b
bored-art-40741
09/22/2015, 3:13 AMIt's because the list starts with interpolation - b
bored-art-40741
09/22/2015, 3:13 AMCopy codetest_opts: %(dev_opts)s + [ - e
enough-analyst-54434
09/22/2015, 3:14 AMYou'll get nuked for that anyhow - b
bored-art-40741
09/22/2015, 3:14 AMIt belongs in the first check - e
enough-analyst-54434
09/22/2015, 3:14 AMI changed eval to ast.literal_eval