#general
- e
enough-analyst-54434
09/18/2015, 11:19 PMaha - gotcha - e
enough-analyst-54434
09/18/2015, 11:19 PMIt would be best to fix the tests - is this like ~25 test files or so? - d
dry-analyst-73584
09/18/2015, 11:20 PMnot sure yet. Still waiting on CI - e
enough-analyst-54434
09/18/2015, 11:20 PMSo - 1 option - e
enough-analyst-54434
09/18/2015, 11:20 PMpeek in kwargs in make_target and if you see sources, touch them all - e
enough-analyst-54434
09/18/2015, 11:20 PMbut that's no good - e
enough-analyst-54434
09/18/2015, 11:21 PMsome tests like yours want the files not to exist - d
dry-analyst-73584
09/18/2015, 11:22 PMyeah. So, I think I can run through all the tests and just add “make_file” to each. Providing it’s not ridiculous. I just wanted to make sure there’s not some other way around this first. - e
enough-analyst-54434
09/18/2015, 11:22 PMNot really - d
dry-analyst-73584
09/18/2015, 11:22 PMok - e
enough-analyst-54434
09/18/2015, 11:23 PMYou could make that nicer for future folks with a new kwarg maybe to make_target, like source_map that took an optional dict of relapth -> contents - e
enough-analyst-54434
09/18/2015, 11:23 PMsource_map={'sub/File.txt': '', 'Jane.txt': 'bob'} - e
enough-analyst-54434
09/18/2015, 11:23 PMthat sort of thing - e
enough-analyst-54434
09/18/2015, 11:23 PMbut I'm not sure thats a great idea - d
dry-analyst-73584
09/18/2015, 11:24 PMso, have “make_target” call “make_file” and add some plumbing? - e
enough-analyst-54434
09/18/2015, 11:24 PMyes - e
enough-analyst-54434
09/18/2015, 11:25 PMbut to mitigate confusion, it may be best to add make_target_with_sources - e
enough-analyst-54434
09/18/2015, 11:25 PMand have it take this new param + rest, create the files, and forward to make_target - e
enough-analyst-54434
09/18/2015, 11:25 PMreally not sure - e
enough-analyst-54434
09/18/2015, 11:25 PMlots of the source_map would be '' values - e
enough-analyst-54434
09/18/2015, 11:26 PMso even, touch_sources={'Jane.txt', 'Bob.txt'}, source_map={'George.txt', 'ipsum'} - e
enough-analyst-54434
09/18/2015, 11:27 PMBut I'm thinking calls to create_file are just fine - d
dry-analyst-73584
09/18/2015, 11:27 PMcool - e
enough-analyst-54434
09/18/2015, 11:28 PMOne note - not all tasks care about files - d
dry-analyst-73584
09/18/2015, 11:28 PMCI finished, looks like there’s actually only four tests that failed. I can fix those now and then work on make_target_with_sources() - e
enough-analyst-54434
09/18/2015, 11:29 PMThis is a bit extreme, but ./pants list should arguably not blow up - e
enough-analyst-54434
09/18/2015, 11:29 PMmost other tasks that use the file should - e
enough-analyst-54434
09/18/2015, 11:29 PMI'm not sure you can do better than you have though given targets and payloads as they work today - e
enough-analyst-54434
09/18/2015, 11:30 PMSo .... scratch that thought - d
dry-analyst-73584
09/18/2015, 11:32 PMOk