#general
- w
witty-crayon-22786
09/17/2015, 2:28 AMheh, but yea... it was a huge deal for us because we weren't using the cache in CI before. - b
bored-art-40741
09/17/2015, 2:30 AMack - b
bored-art-40741
09/17/2015, 2:30 AMMost of my cluster compile filed from too many open files on junit tests - b
bored-art-40741
09/17/2015, 2:30 AMWhelp - w
witty-crayon-22786
09/17/2015, 2:31 AMhm. it should be using the jars there... how many targets are involved? - b
bored-art-40741
09/17/2015, 2:31 AMLots - b
bored-art-40741
09/17/2015, 2:31 AMCopy code.......................[init] error: error while loading <root>, .pants.d/compile/jvm/zinc/jars/7c571a687274.jar (Too many open files) - b
bored-art-40741
09/17/2015, 2:31 AMThat's a new one - w
witty-crayon-22786
09/17/2015, 2:32 AMthat is one of the jars created by isolated compile - b
bored-art-40741
09/17/2015, 2:32 AMIf this is just about ulimits we can fix that easily - w
witty-crayon-22786
09/17/2015, 2:32 AMyea, it's just ulimits. - w
witty-crayon-22786
09/17/2015, 2:35 AMback in 20 - f
fancy-queen-20734
09/17/2015, 5:12 PMhttps://rbcommons.com/s/twitter/r/2841/ While I think people probably shouldn’t use variables in this way in BUILD files, we shouldn’t be modifying the values they pass in. - w
witty-crayon-22786
09/17/2015, 5:16 PMshipit - b
bored-art-40741
09/17/2015, 7:55 PM@enough-analyst-54434: Trying to make some time while in the air to look at your jar product refactor. Is there a preferred order in which to do these reviews? - e
enough-analyst-54434
09/17/2015, 7:56 PMThe order sent out - b
bored-art-40741
09/17/2015, 7:56 PMk - e
enough-analyst-54434
09/17/2015, 7:56 PMPretty much top-to bottom the bugs linked at the bottom here: https://github.com/pantsbuild/pants/issues/1841 - e
enough-analyst-54434
09/17/2015, 7:57 PMThough some are tangential enough yaks you can skip to next - m
mammoth-pharmacist-54215
09/17/2015, 8:55 PMdo we intentionally format log messages like this or was it a typo? It looks like its missing the leading [ WARN] While parsing FilesystemBuildFile... - r
rough-minister-58256
09/17/2015, 9:01 PMthink it’s intentional - at least that’s been the default format for t.c.log etc for as long as I can remember. - r
rough-minister-58256
09/17/2015, 9:01 PM - r
rough-minister-58256
09/17/2015, 9:02 PM - r
rough-minister-58256
09/17/2015, 9:04 PMcould be a goog thing e.g. perhaps their research indicated that saving one character on each log equates to $$$$ savings - m
mammoth-pharmacist-54215
09/17/2015, 9:04 PMlol - e
enough-analyst-54434
09/17/2015, 9:16 PMNope - we use a $$$ wasteful format WARN instead of just W, the canonical format: https://github.com/google/glog/blob/master/src/glog/logging.h.in#L279-L301 Implemented here: https://github.com/twitter/commons/blob/master/src/python/twitter/common/log/formatters/glog.py And here: https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/logging/Glog.java - m
mammoth-pharmacist-54215
09/17/2015, 9:19 PMI’m fine with 👖WARN👖 Message as long as that’s what was intended simple smile Although unicode chars in logs are fun times. - m
mammoth-pharmacist-54215
09/17/2015, 9:20 PMJust wanted to make sure no one accidentally did it, I noticed it while I was doing some builds today. - r
rough-minister-58256
09/17/2015, 9:20 PMif you replace the level with an indicator emoji, even more savings - m
mammoth-pharmacist-54215
09/17/2015, 9:20 PM😡 - > FATAL