https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    09/17/2015, 12:36 AM
    Always be raw stringing
  • b

    bored-art-40741

    09/17/2015, 12:37 AM
    PS after several stress compiles and now a full CI suite, your fix appears to be working great, Stu
  • b

    bored-art-40741

    09/17/2015, 12:37 AM
    I'm probably going to push the upgrade to isolated strategy internally tonight
  • b

    bored-art-40741

    09/17/2015, 12:37 AM
    ...And then hop on a plane for the midwest tomorrow
  • r

    rough-minister-58256

    09/17/2015, 12:41 AM
    @witty-crayon-22786: could it be the unescaped )’s in the []*s?
  • w

    witty-crayon-22786

    09/17/2015, 12:42 AM
    iirc, that's valid
  • w

    witty-crayon-22786

    09/17/2015, 12:42 AM
    inside a character class you don't escape things
  • w

    witty-crayon-22786

    09/17/2015, 12:43 AM
    (checking the raw string thing)
  • w

    witty-crayon-22786

    09/17/2015, 12:43 AM
    to be clear: this works in a repl on 2.7.10
  • r

    rough-minister-58256

    09/17/2015, 12:44 AM
    the ‘nothing to repeat’ leads me to believe its related to modifiers that repeat, which is * (or possibly ?) here
  • m

    mammoth-pharmacist-54215

    09/17/2015, 12:44 AM
    its possible it’s a bug that was fixed in 2.7.10
  • r

    rough-minister-58256

    09/17/2015, 12:44 AM
    doesnt work in older 2.7?
  • w

    witty-crayon-22786

    09/17/2015, 12:44 AM
    we'll see. not sure precisely which version that exception came from.
  • w

    witty-crayon-22786

    09/17/2015, 12:45 AM
    chroot doesn't actually say which interpreter it chose...
  • w

    witty-crayon-22786

    09/17/2015, 12:45 AM
    Copy code
    17:43:55 00:02     [py]
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.8.tmp.abf5b8a369e145b9a691c8cdab522b62/setuptools-5.4.1-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.8.tmp.abf5b8a369e145b9a691c8cdab522b62/wheel-0.24.0-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.8/setuptools-5.4.1-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.8/wheel-0.24.0-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.10.tmp.e3e217d43e984c7f9896405265d300d0/wheel-0.24.0-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.10/setuptools-5.4.1-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.10/wheel-0.24.0-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.5.tmp.e766f37cce264a3cb56689965f736461/setuptools-5.4.1-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.5.tmp.e766f37cce264a3cb56689965f736461/wheel-0.24.0-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.5/setuptools-5.4.1-py2.7.egg
                       installed /Users/stuhood/src/pants_internal/.pants.d/python-setup/interpreters/CPython-2.7.5/wheel-0.24.0-py2.7.egg
17:44:18 00:25       [chroot]
  • m

    mammoth-pharmacist-54215

    09/17/2015, 12:46 AM
    we could probably use some more logging there 😞
  • b

    bored-art-40741

    09/17/2015, 12:47 AM
    Speaking from experience, python 2.x's regex parsing is pure insanity
  • b

    bored-art-40741

    09/17/2015, 12:48 AM
    I strongly recommend that you never read that code
  • r

    rough-minister-58256

    09/17/2015, 12:58 AM
    I repro in 2.7.5:
    Copy code
    Python 2.7.5 (default, Sep 16 2015, 17:57:16) 
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import re; re.compile('cr([lj])\(([^!)]*)!?([^)]*)?\)')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/kwilson/.pythonz/pythons/CPython-2.7.5/lib/python2.7/re.py", line 190, in compile
    return _compile(pattern, flags)
  File "/Users/kwilson/.pythonz/pythons/CPython-2.7.5/lib/python2.7/re.py", line 242, in _compile
    raise error, v # invalid expression
sre_constants.error: nothing to repeat
>>>
  • b

    bored-art-40741

    09/17/2015, 12:58 AM
    Yuck, we appear to be using a bit more disk space than before
  • w

    witty-crayon-22786

    09/17/2015, 12:58 AM
    aha. yea, so that's coming from somewhere. need to nuke it.
  • b

    bored-art-40741

    09/17/2015, 12:58 AM
    Defeated by our own ramdisks in the end
  • m

    mammoth-pharmacist-54215

    09/17/2015, 12:58 AM
    congrats, sounds like you found a python bug… the good news is its fixed in newer versions.
  • w

    witty-crayon-22786

    09/17/2015, 12:59 AM
    @bored-art-40741: ha. yea. you'll use 2X (edit 2x), afaik
  • b

    bored-art-40741

    09/17/2015, 12:59 AM
    Oh, that's a known number?
  • w

    witty-crayon-22786

    09/17/2015, 12:59 AM
    we jar the classpath after it is compiled
  • w

    witty-crayon-22786

    09/17/2015, 12:59 AM
    uncompressed
  • b

    bored-art-40741

    09/17/2015, 12:59 AM
    Aha
  • w

    witty-crayon-22786

    09/17/2015, 12:59 AM
    so expecting at least 2X more.
  • w

    witty-crayon-22786

    09/17/2015, 12:59 AM
    obviously, jar patch makes that go away
1...380381382...2420Latest