https://pantsbuild.org/ logo
Powered by
#general
  • l

    limited-country-20626

    09/16/2015, 4:35 PM
    okay, doc should be accessible now.
  • w

    witty-crayon-22786

    09/16/2015, 5:11 PM
    @bored-art-40741: are you guys using the 
    -force-clean
    flag to zinc? its benefit is unclear, and it required a feature that i was interested in pruning
  • h

    happy-kitchen-89482

    09/16/2015, 5:12 PM
    I don't think so. What does that do
  • h

    happy-kitchen-89482

    09/16/2015, 5:12 PM
    ?
  • w

    witty-crayon-22786

    09/16/2015, 5:12 PM
    if the analysis for a directory is empty, it forces a full rebuild
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:13 PM
    @witty-crayon-22786: how is it currently called is it passed as an argument to compile?
  • w

    witty-crayon-22786

    09/16/2015, 5:13 PM
    passed as an argument to zinc, which is a compile option
  • w

    witty-crayon-22786

    09/16/2015, 5:14 PM
    it might be worth keeping, but i think i'd rather explode even
  • w

    witty-crayon-22786

    09/16/2015, 5:14 PM
    ...and we can do that outside zinc
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:15 PM
    Can we deprecate the option rather than just nuking it? I’d like to get away from breaking changes when possible.
  • w

    witty-crayon-22786

    09/16/2015, 5:15 PM
    @mammoth-pharmacist-54215: do you know what zinc is?
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:15 PM
    not my wheelhouse tbh
  • h

    happy-kitchen-89482

    09/16/2015, 5:15 PM
    if pants doesn't plumb that through then we'd have to be setting it as an extra zinc option in pants.ini, which we are not.
  • h

    happy-kitchen-89482

    09/16/2015, 5:15 PM
    So nuke away.
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:16 PM
    @witty-crayon-22786: I know basics of zinc… but honestly only what I’ve picked up since I started working here at twitter.
  • w

    witty-crayon-22786

    09/16/2015, 5:17 PM
    @mammoth-pharmacist-54215: we brought zinc into pants mostly to completely own the API... our goal is mostly to shrink it
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:18 PM
    I understand the desire to shrink it, and I’m not opposed to that. Less complexity is usually a good thing.
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:18 PM
    I just think it would be good if we got into the habit of changing behavior in a way that doesn’t potentially break people using the existing code base and gives them a clear migration path.
  • h

    happy-kitchen-89482

    09/16/2015, 5:19 PM
    zinc is an implementation detail of pants, not a thing end-users interact with.
  • h

    happy-kitchen-89482

    09/16/2015, 5:19 PM
    removing a zinc option is akin to changing an internal pants API
  • h

    happy-kitchen-89482

    09/16/2015, 5:19 PM
    it's not scary like changing a pants option would be
  • m

    mammoth-pharmacist-54215

    09/16/2015, 5:19 PM
    I thought we just went through discussing that we can set this option either on the command line or in pants.ini...
  • b

    billowy-alarm-80641

    09/16/2015, 5:19 PM
    which it would be good to have a deprecation cycles for too
  • b

    billowy-alarm-80641

    09/16/2015, 5:19 PM
    I agree w/ Matt that in general, it's better to have a deprecation cycle
  • b

    billowy-alarm-80641

    09/16/2015, 5:19 PM
    but in this instance it's probably okay not to
  • w

    witty-crayon-22786

    09/16/2015, 5:19 PM
    @billowy-alarm-80641: definitely not for internal apis.
  • b

    billowy-alarm-80641

    09/16/2015, 5:20 PM
    once we hit 1.0, we'll have to
  • w

    witty-crayon-22786

    09/16/2015, 5:20 PM
    that's the definition of an internal api
  • h

    happy-kitchen-89482

    09/16/2015, 5:20 PM
    There's no pants option that maps to that 1:1
  • b

    billowy-alarm-80641

    09/16/2015, 5:20 PM
    if it's something that can be called
1...373374375...2420Latest