https://pantsbuild.org/ logo
Powered by
#general
  • w

    witty-crayon-22786

    09/15/2015, 10:08 PM
    @bored-art-40741: #shipit
  • b

    bored-art-40741

    09/15/2015, 10:08 PM
    Thanks!
  • w

    witty-crayon-22786

    09/15/2015, 10:08 PM
    i expect you'll need to cherry pick it somewhere regardless though... lots of ivy churn in master
  • b

    bored-art-40741

    09/15/2015, 10:09 PM
    We're operating off of a forked distribution for a while anyway while things settle on isolated
  • w

    witty-crayon-22786

    09/15/2015, 10:09 PM
    k
  • b

    bored-art-40741

    09/15/2015, 10:09 PM
    (Even if the "fork" is tracking a regular release anyway)
  • b

    bored-art-40741

    09/15/2015, 10:19 PM
    How do people feel about a little script + environment variable 
    PANTS_PROFILE
    that's similar to 
    PEX_PROFILE
    but works if pants is just run out of a virtualenv?
  • b

    bored-art-40741

    09/15/2015, 10:19 PM
    I think it's harmless enough since it's guarded by an env variable
  • w

    witty-crayon-22786

    09/15/2015, 10:21 PM
    iirc, that's already there
  • b

    bored-art-40741

    09/15/2015, 10:22 PM
    Oh?
  • w

    witty-crayon-22786

    09/15/2015, 10:22 PM
    yea. crack open 
    pants
  • b

    bored-art-40741

    09/15/2015, 10:22 PM
    Ah, I see
  • w

    witty-crayon-22786

    09/15/2015, 10:22 PM
    may or may not be working, but
  • b

    bored-art-40741

    09/15/2015, 10:22 PM
    This goes the extra step of generating a nice graph
  • b

    bored-art-40741

    09/15/2015, 10:23 PM
    I guess they're separable
  • e

    enough-analyst-54434

    09/15/2015, 10:25 PM
    The talk references still working on getting on 1 version of pants ... is this an old talk?
  • w

    witty-crayon-22786

    09/15/2015, 10:26 PM
    no, occurred yesterday. he eventually describes where we are today, but he doesn't spend neeeearly enough time on it
  • w

    witty-crayon-22786

    09/15/2015, 10:26 PM
    it's basically "and then i joined and in a few months we fixed those things"
  • e

    enough-analyst-54434

    09/15/2015, 10:26 PM
    k - he's talked about 2 versions of pants still 2x
  • w

    witty-crayon-22786

    09/15/2015, 10:26 PM
    😃
  • f

    fancy-queen-20734

    09/15/2015, 10:26 PM
    PEX_PROFILE is partly broken
  • w

    witty-crayon-22786

    09/15/2015, 10:27 PM
    Copy code
    Compile used 0 / 438 analysis files.
    ... ffs
  • w

    witty-crayon-22786

    09/15/2015, 10:27 PM
    (target has no dependencies, declares two massive dependencies)
  • r

    rough-minister-58256

    09/15/2015, 10:38 PM
    @bored-art-40741: that won’t get you profiling information for threads tho. I have a small yappi stub that I inject into pants_exe.py for full blown profiling that might be nice to drop somewhere
  • b

    bored-art-40741

    09/15/2015, 10:38 PM
    I'd be interested in seeing that. We weren't really concerned with work going on in threads, and we generally haven't been in a while
  • b

    bored-art-40741

    09/15/2015, 10:39 PM
    The only time we've wanted to know about concurrent behavior in pants was for artifact cache fetching and unpacking, which had some big perf issues for a while
  • b

    bored-art-40741

    09/15/2015, 10:40 PM
    If anything CPU bound is being done in threads in python without being offloaded a native speedup plugin, you've already lost
  • r

    rough-minister-58256

    09/15/2015, 10:46 PM
    yeah, threads -> nailguns seem like a good combo
  • b

    bored-art-40741

    09/15/2015, 10:46 PM
    Yeah
  • b

    bored-art-40741

    09/15/2015, 10:47 PM
    @witty-crayon-22786: I'm confused--are you saying there's a correctness issue where we aren't consuming analysis properly?
1...367368369...2420Latest