https://pantsbuild.org/ logo
Powered by
#general
  • b

    bored-art-40741

    09/15/2015, 5:02 PM
    Copy code
    commit 1bff7c0d1bc76b0d8fd0364070b0a41e38390934
Author: Stu Hood <stuhood@gmail.com>
Date:   Fri Sep 4 17:21:49 2015 -0700

    Don't create directory entries in the isolated context jar

    - Creating directory entries in the isolated context jar causes directory entries in classes_by_target... but we don't need directory entries for jars containing classfiles.
  • w

    witty-crayon-22786

    09/15/2015, 5:04 PM
    shouldn't have a huge effect on performance, although it will have some effect
  • b

    bored-art-40741

    09/15/2015, 5:05 PM
    We're not working on perf issues at this point
  • b

    bored-art-40741

    09/15/2015, 5:05 PM
    We're back to correctness
  • w

    witty-crayon-22786

    09/15/2015, 5:11 PM
    ok.
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:11 PM
    @enough-analyst-54434: Do we intend on continuing to support both resource_targets and resources attribs in python_library’s?
  • e

    enough-analyst-54434

    09/15/2015, 5:11 PM
    No
  • w

    witty-crayon-22786

    09/15/2015, 5:11 PM
    @bored-art-40741: we have a list of known issues around incremental compile, but nothing like that.
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:13 PM
    Sorry I’m just looking through your CR now, it doesn’t look like you killed the old behavior yet. I haven’t finished stepping through it though.
  • e

    enough-analyst-54434

    09/15/2015, 5:13 PM
    Correct - out of scope
  • e

    enough-analyst-54434

    09/15/2015, 5:13 PM
    It needs a deprecation RB
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:14 PM
    It like you read my mind simple smile So we plan to have it marked as deprecated somehow for people?
  • e

    enough-analyst-54434

    09/15/2015, 5:14 PM
    s/we//
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:14 PM
    haha
  • e

    enough-analyst-54434

    09/15/2015, 5:14 PM
    But probably if someone decided they wanted to do this, it would be a good thing
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:14 PM
    as long as someone does it before we kill the old behavior simple smile
  • e

    enough-analyst-54434

    09/15/2015, 5:14 PM
    I was just shaving #1841 yaks
  • m

    mammoth-pharmacist-54215

    09/15/2015, 5:15 PM
    yup, understood. Sounds like we are on the same page
  • e

    enough-analyst-54434

    09/15/2015, 5:15 PM
    cool
  • b

    billowy-alarm-80641

    09/15/2015, 5:46 PM
    I'm looking at https://rbcommons.com/s/twitter/r/2823, it looks like we're still using 
    ivy_jar_products
    internally
  • b

    bored-art-40741

    09/15/2015, 5:51 PM
    Okay have a very clean repro of this bug @witty-crayon-22786
  • b

    bored-art-40741

    09/15/2015, 5:51 PM
    Copy code
    7d2d053f70636f460a82a5cae07da9d0afa9e200-TaskIdentityFingerprintStrategy.10442c7fcb2a_62d21e46622b

7d2d053f70636f460a82a5cae07da9d0afa9e200-TaskIdentityFingerprintStrategy.4ccf271ce757_62d21e46622b
  • b

    bored-art-40741

    09/15/2015, 5:51 PM
    We're getting instability on the transitive hash of a specific target
  • w

    witty-crayon-22786

    09/15/2015, 5:52 PM
    @billowy-alarm-80641: we needn't be
  • b

    bored-art-40741

    09/15/2015, 5:52 PM
    It's just a scala_library with nothing special about it
  • b

    billowy-alarm-80641

    09/15/2015, 5:52 PM
    @witty-crayon-22786: it's in our fork of ide_gen
  • w

    witty-crayon-22786

    09/15/2015, 5:52 PM
    right.
  • b

    billowy-alarm-80641

    09/15/2015, 5:52 PM
    I don't know why we have that
  • b

    billowy-alarm-80641

    09/15/2015, 5:52 PM
    or how is easy it is to kill or get w/ the new program
  • b

    billowy-alarm-80641

    09/15/2015, 5:53 PM
    In John's RB I don't see where he touches the ide_gen code
1...362363364...2420Latest