#general
- b
bored-art-40741
09/11/2015, 5:11 PMWe generally
until green, thencompile-changed --direct-dependeestest-changed --direct-dependees - b
bored-art-40741
09/11/2015, 5:11 PMAnything that speeds up fast incremental compiles is very valuable to us - w
witty-crayon-22786
09/11/2015, 5:12 PMwell, sure. but you see my point - w
witty-crayon-22786
09/11/2015, 5:12 PMit shouldn't be necessary to have two steps there - w
witty-crayon-22786
09/11/2015, 5:13 PM@bored-art-40741: oh! when you tested isolated, did you turn off the dep check? - w
witty-crayon-22786
09/11/2015, 5:13 PMspecifically, did you pass
?--compile-jvm-dep-check-skip - w
witty-crayon-22786
09/11/2015, 5:14 PMbecause that will skip generating product_deps_by_src - b
bored-art-40741
09/11/2015, 5:17 PMI did - e
enough-analyst-54434
09/11/2015, 5:17 PMWhy classes_by_source new round engine?: check the options?: https://github.com/jsirois/pants/blob/master/src/python/pants/backend/jvm/tasks/junit_run.py#L814-814 - e
enough-analyst-54434
09/11/2015, 5:18 PM~1 line fix w/o tests - w
witty-crayon-22786
09/11/2015, 5:18 PMyea, good call. - w
witty-crayon-22786
09/11/2015, 5:19 PM@bored-art-40741: mind doing that one? - e
enough-analyst-54434
09/11/2015, 5:19 PMConditional products does not require the new engine, just fine grained products - b
bored-art-40741
09/11/2015, 5:20 PMI'm going to defer to Mateo on the actionable stuff here, I'm off in hadoop land while Mateo takes care of our isolated engine upgrade - w
witty-crayon-22786
09/11/2015, 5:20 PM@enough-analyst-54434: it does for product_deps_by_src: see above - w
witty-crayon-22786
09/11/2015, 5:20 PM@enough-analyst-54434: the jvm-dep-check only needs to request products for invalid targets - e
enough-analyst-54434
09/11/2015, 5:20 PMfine grained - w
witty-crayon-22786
09/11/2015, 5:21 PMnot getting it =/ - b
bored-art-40741
09/11/2015, 5:21 PMI don't really care about jvm-dep-check. We're moving to isolated, we can at this point just pretend that global is dead and make sure isolated is meeting our needs - e
enough-analyst-54434
09/11/2015, 5:21 PMtoday a product request is global, but conditional - w
witty-crayon-22786
09/11/2015, 5:21 PMofficially? - e
enough-analyst-54434
09/11/2015, 5:21 PMne engine it will be a request per target or finer grained node, and conditional - b
bored-art-40741
09/11/2015, 5:21 PMWe're going to do some more thorough and quantitative perf testing today and report on our findings - w
witty-crayon-22786
09/11/2015, 5:22 PM@bored-art-40741: ok. in the mean time, shall i start a review to remove global? - e
enough-analyst-54434
09/11/2015, 5:22 PMYay! - e
enough-analyst-54434
09/11/2015, 5:22 PMI'll hit the product fix, I'm removing a dead product now as it happens - w
witty-crayon-22786
09/11/2015, 5:22 PMthanks john - h
happy-kitchen-89482
09/11/2015, 6:01 PMlet's give the move to isolated a couple more days before we nuke global... - h
happy-kitchen-89482
09/11/2015, 6:01 PMI'm 99% sure we'll be fine, but we're not quite there yet - f
fancy-queen-20734
09/11/2015, 6:22 PMWhere would be a good place to put an integration test for ensuring buildcache doesn’t cause compile issues?