#general
- e
enough-analyst-54434
09/09/2015, 12:28 AMThanks for pushing things around - I think this is a better place to be - b
bored-art-40741
09/09/2015, 1:08 AMre @enough-analyst-54434 "Folks - are you a control freak? Do you drool when you have the leverage to lock things down? Look no further!":http://cdn.toucharcade.com/wp-content/uploads/2015/07/shut-up-and-take-my-money.jpg▾
- b
bored-art-40741
09/09/2015, 1:08 AMReviewing now - r
rough-minister-58256
09/09/2015, 1:09 AMsimple smile - e
enough-analyst-54434
09/09/2015, 1:09 AMThanks Patrick - do note that the target_macro_factories BuildFileAliases slot is being merged into the existing targets slot per discussion here and on that RB with Stu - e
enough-analyst-54434
09/09/2015, 1:55 AMK - my implementation of the "targets"/"target_factry_macros" BuildFileAliases smoosh is in on the RB - hands off until further review notice from you all. - b
bored-art-40741
09/09/2015, 1:59 AMOh did I miss a diff in my review? - b
bored-art-40741
09/09/2015, 2:00 AMI did 😕 - b
bored-art-40741
09/09/2015, 2:00 AMTime to review a diff of a diff! - e
enough-analyst-54434
09/09/2015, 2:02 AMIts tiny - e
enough-analyst-54434
09/09/2015, 2:02 AMJust shoves TargetMacro.Factory instances into "targets" - b
bored-art-40741
09/09/2015, 2:03 AMYeah, seems fine to me - b
bored-art-40741
09/09/2015, 2:03 AMShip stands - e
enough-analyst-54434
09/09/2015, 2:03 AMso that slot has either Target subtypes, or macro factory instances now - to prevent future thrash when/if Target grows macro capabilities - e
enough-analyst-54434
09/09/2015, 2:03 AMk - thanks for looking - e
enough-analyst-54434
09/09/2015, 2:03 AMI'm hoping to circle back in the next 2 weeks to make Addressables handled by BuildGraph - b
bored-art-40741
09/09/2015, 2:04 AMAnd I'm glad someone else has now done a full dive on the target/addressable side of things - e
enough-analyst-54434
09/09/2015, 2:04 AMand then drop my Go Target dependencies denial checks - e
enough-analyst-54434
09/09/2015, 2:04 AMAnd just change those things - GoRemoteLibraries - to Addressables and not Targets - e
enough-analyst-54434
09/09/2015, 2:05 AMYup - the more you know the better. It was good to get into this code again - b
bored-art-40741
09/09/2015, 2:06 AMIt was nostalgic for me to read all of that code, heh. It was my first non-trivial pants project, and it spiraled into a serious mega-change - b
bored-art-40741
09/09/2015, 2:07 AMGlad it's more or less held up to the test of time - e
enough-analyst-54434
09/09/2015, 2:09 AMYup - all solid. The only wart is Addressable handling and I'm pretty sure that only sprouted a wart because we had no real registration of a pure Addressable - e
enough-analyst-54434
09/09/2015, 2:09 AMWe will though in a few weeks - b
bored-art-40741
09/09/2015, 2:09 AMI went down that route once upon a time - b
bored-art-40741
09/09/2015, 2:09 AMHad a patch and tests and everything--but ended up throwing it away - e
enough-analyst-54434
09/09/2015, 2:09 AMI have a feeling it will take me 5 tries - b
bored-art-40741
09/09/2015, 2:10 AMBecause I wasn't convinced it made sense - e
enough-analyst-54434
09/09/2015, 2:10 AMYeah - exactly - e
enough-analyst-54434
09/09/2015, 2:10 AMPicking the nouns and verbs will take some back and forth to get right